[Mldonkey-users] [patch #5596] EDK: New option upload_full_chunks

[TripleM]

Follow-up Comment #3, patch #5596 (project mldonkey):

lines 49-53 and 195-198 of your patch are pure wrong, imho.
+  List.iter (fun (file, chunks, up) ->
+    try CommonSwarming.unregister_uploader up with _ -> ()
+  ) c.client_file_queue;
+  c.client_file_queue <- []
CommonSwarming-uploaders are not the clients, you upload to, but from which
you download. if you unregister a client there, you stop the download from
this client. same goes for emptying client_file_queue, these are the files,
you are interested in.

both are misplaced in DonkeyOneFile.remove_client_slot, i think, cause we
want to stop uploading to this client, but dont want to stop downloading, if
we do this atm. they should stay indeed in DonkeyClient.disconnect_client.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5596>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/