[Mldonkey-users] [patch #6337] Fix inequality test for option html_mods_theme

[spiralvoice]

URL:
  <http://savannah.nongnu.org/patch/?6337>

                 Summary: Fix inequality test for option html_mods_theme
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: spiralvoice
            Submitted on: Sonntag 09.12.2007 um 21:38
                Category: Bug fixes
                Priority: 5 - Normal
                  Status: Works For Me
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

thx to pango

[21:31:55] <pango> [18:30:02] btw there's a (small) bug, in several place
there's !!html_mods_theme != ""
[21:31:55] <pango> [18:30:22] != is physical equality, so this test is always
true
[21:31:55] <pango> [18:30:33] (physical inequality, rather)
[21:31:55] <pango> [18:30:45] # "" != "" ;;
[21:31:55] <pango> [18:30:45] - : bool = true
[21:31:55] <pango> [18:31:01] it should be !!html_mods_theme <> ""
[21:31:55] <pango> [18:31:11] (structural inequality)
[21:31:55] <pango> [18:31:42] consequence is that mlnet looks for overriding
pages in the filesystem, even when no theme is set
[21:31:55] <pango> [18:32:26] so there's just a small performance hit



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sonntag 09.12.2007 um 21:38  Name: html_mods_theme_fix_inequality.patch
 Size: 5kB   By: spiralvoice

<http://savannah.nongnu.org/patch/download.php?file_id=14599>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6337>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/