[Mldonkey-users] [patch #8415] Revert "gettext: reduce complexity, drop unused code" to fix GTK2 gui's compilation

[spiralvoice]

URL:
  <http://savannah.nongnu.org/patch/?8415>

                 Summary: Revert "gettext: reduce complexity, drop unused
code" to fix  GTK2 gui's compilation
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: dcoppa_openbsd
            Submitted on: Sa 22 Mär 2014 12:03:02 CET
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: None
        Operating System: None
         Binaries Origin: None
                CPU type: None

    _______________________________________________________

Details:


Hi!

The commit "gettext: reduce complexity, drop unused code"
(d7e9f64f7c1fcd86e7a2b56f0951245386811942) broke GTK2 gui's compilation:

---8<---

ocamlopt.opt -inline 10    -I src/utils/extlib  -I src/utils/cdk  -I
src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I
src/utils/xml-light  -I
 src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I
src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11 
-I src
/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect 
-I src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent
-I src/networks/donkey -I +camlp4 -c src/gtk2/gui/guiMessages.ml

File "src/gtk2/gui/guiMessages.ml", line 197, characters 38-46:
Error: Unbound module T
Makefile:5461: recipe for target 'src/gtk2/gui/guiMessages.cmx' failed
make: *** [src/gtk2/gui/guiMessages.cmx] Error 2

---8<---

I think a (at least partial) revert is needed.


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: So 04 Apr 2004 12:21:39 CEST  By: Richard Baumann <Rich333>
Duplicate of bug #8393.

-------------------------------------------------------
Date: Fr 02 Apr 2004 22:23:39 CEST  By: Kees Jongenburger <keesj>
possible fix:
in XmlTextReader.cs add 
if (empty) 
{
 nodes.EndElement.SetInfo(localName, name, namespaceURI, prefix);
}

at row 1983.



-------------------------------------------------------
Date: Fr 02 Apr 2004 09:15:36 CEST  By: Kees Jongenburger <keesj>
this is the same bug as
http://savannah.gnu.org/bugs/?func=detailitem&item_id=8393

if you edit the xml file with vi and run
:%s,\(<\([^\w]*\) [^>]*\)/>,\1></\2>,g
the test pases


 





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fr 02 Apr 2004 09:17:05 CEST  Name: shit.xml  Size: 76kB   By: keesj
modified test xml file that pases the test
<http://savannah.nongnu.org/bugs/download.php?file_id=1166>
-------------------------------------------------------
Date: Do 01 Apr 2004 22:31:30 CEST  Name: xmlbug.tar.gz  Size: 8kB   By: Ilyak
This is test case!
<http://savannah.nongnu.org/bugs/download.php?file_id=1165>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?8415>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/