RE: beta release

[Jan-Henrik Haukeland]

> > I found out that we need something like this when I got a SIGSEGV when
> > I tested the ssl functions and did not add a client cert.
>
> By bug or fiddling in the code???

I tested with only setting the server pem file and not setting a client.pem.
The check_ssl_files (I think it is called, I'm on windows right now and cannot
check the code) pass the Run.clientpem directely to check_file and since
Run.clientpem was not set and had a NULL value it lead to a SIGSEGV in
check_file. So you could say it's kind of a bug, which the use_ssl function I
sent earlier is trying to avoid.

> httpdssl -> the ssl server support [en|dis]abled
> clientssl -> client cert check of the  ssl server support [en|dis]abled
> servicessl -> ssl service check support [en|dis]abled

Yep

> I don't like it to be in ssl.c.  The first plan of mine for ssl.c to
> let it know the least of monit.  Unfortunately I implemented the
> clientcert stuff later. So, I still have this ugly Run.clienthttpdpem
> stuff in it.  It's on TODO: Clean up of ssl.c .
>
> I prefer it to be in monitor.c, cause it has more the taste of an init
> func  for monit.
>
> Maybe we should build an init.c file to place there all the
> initialization stuff from monitor.c.

Maybe use env.c since this is sort of a placeholder for init stuff.

> *
> Actually we don't need the start_ssl anymore in monitor.c.  I have
> made ssl.c completely self initializing upon first object creation.
> This is necessary, because I already use the ssl.c when the config
> file is parsed for creating the ssl sockets for the services.

Okay

> We can make use_ssl just to check all the necessary files.

Yes, my idea as well

> > So I propose that we postpone the beta release until everything is tip
> > top, what do you think?
>
> Good idea.  Monit is a security related software.  And the code should
> reflect it.  That includes that we have a critical eye on each others
> code.


Good, btw, Martin we should try to add the changes to the autostart statement
also in the 3.1 release, do you have time to do it?

Jan-Henrik