[monit-dev] 5.1: spurious argument in console log

[Michael Shigorin]

        Hello,
thanks for Monit 5.1, and it seems like something gets wrong
with at least some console output in a 8-bit locale:

$ sudo monit monitor cupsd_bin
h╟:6: Warning: check system service not defined -- adding virtual service 
'check system host.name' 'root'
$ sudo monit monitor cupsd_bin
x:6: Warning: check system service not defined -- adding virtual service 'check 
system host.name' 'root'
$ sudo monit monitor cupsd    
╗V      :6: Warning: check system service not defined -- adding virtual service 
'check system host.name' 'root'
$ sudo monit monitor cupsd
ья:6: Warning: check system service not defined -- adding virtual service 
'check system host.name' 'root'

so that first argument looks like junk.

Looking in p.y, I can't figure out the problem at a glance.
Could it be a miscompile? (tried twice with the same result)


This happens with my own package off monit-5.1.tar.gz and
that old pkgconfig patch (attached for reference, we agreed
it's not upstreamable) on:

Linux host.name 2.6.18-ovz-rhel-alt11 #1 SMP Thu Sep 10 17:53:35 UTC 2009 
x86_64 GNU/Linux

Target: x86_64-alt-linux
Configured with: ../configure --host=x86_64-alt-linux
--build=x86_64-alt-linux --target=x86_64-alt-linux --prefix=/usr
--exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin
--sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include
--libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var/lib
--sharedstatedir=/usr/com --mandir=/usr/share/man
--infodir=/usr/share/info --disable-dependency-tracking
--without-included-gettext --program-suffix=-4.4 --with-slibdir=/lib64
--with-bugurl=http://bugzilla.altlinux.org --enable-bootstrap
--enable-shared --enable-__cxa_atexit --enable-threads=posix
--enable-checking=release --with-system-zlib --without-included-gettext
--enable-multilib --enable-languages=c,c++,fortran,objc,obj-c++,java,ada
--enable-java-awt=gtk --disable-plugin
--with-native-libdir=/usr/lib64/gcj-4.4
--with-ecj-jar=/usr/share/java/ecj.jar
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.4-1.5.0.0/jre
--enable-libgcj-multifile --disable-libjava-multilib
--enable-java-maintainer-mode --with-arch_32=i586 --with-tune_32=generic
Thread model: posix
gcc version 4.4.2 20091222 (ALT Linux 4.4.2-alt2.M51.1) (GCC) 

Also building by hand from source with the patch applied:

./configure --without-ssl --sysconfdir=/etc
make

(plain make or make -j on a quad-core doesn't make any difference)
and then running the obtained binary leads each time to:

does *not* make any difference.


This seems *not* to happen while trying to printf-debug in this way:

--- a/p.y
+++ b/p.y
@@ -1730,6 +1730,7 @@ void yywarning2(const char *s, ...) {
   ASSERT(s);
   
   va_start(ap,s);
+  LogWarning("[%s]\n");
   msg = Util_formatString(s, ap, &len);
   va_end(ap);

then building:

./configure --without-ssl --sysconfdir=/etc
make

(plain make or make -j on a quad-core doesn't make any difference)
and then running the obtained binary leads *each time* to:

[host.name]         
KMT:6: Warning: check system service not defined -- adding virtual service 
'check system host.name' 'root'

If I apply the same patch to the package, the result is the same.

What should I do to track this down?  Once upon a time I've written
a tiny bit of code in C but mostly had to read/patch others' since;
yacc is definitely not my item at all.

-- 
 ---- WBR, Michael Shigorin <address@hidden>
  ------ Linux.Kiev http://www.linux.kiev.ua/

monit-5.1-pkgconfig-configure.patch
Description: Text document