# # patch "ChangeLog" # from [0087b8ab7e78fe6c92de53d7098293dfea3b8ea1] # to [ff7c650f7c29da4d4ebdd2b605d69789cac7d26d] # # patch "netsync.cc" # from [689952c3bc271d9e74e548ebdc7dddecdc012ff6] # to [5c9a20e2218f5d684ec47b282622aa42d839bf1c] # ======================================================================== --- ChangeLog 0087b8ab7e78fe6c92de53d7098293dfea3b8ea1 +++ ChangeLog ff7c650f7c29da4d4ebdd2b605d69789cac7d26d @@ -1,3 +1,7 @@ +2005-08-16 Nathaniel Smith + + * netsync.cc: Add more netsync todos. + 2005-08-15 Nathaniel Smith * tests/t_explicit_merge_with_anc.at: New test. ======================================================================== --- netsync.cc 689952c3bc271d9e74e548ebdc7dddecdc012ff6 +++ netsync.cc 5c9a20e2218f5d684ec47b282622aa42d839bf1c @@ -62,8 +62,18 @@ // for the server to send back to the client "right, you're not getting // the following branches: ...", so the client will not include them in // its merkle trie. -// -- add some sort of vhost field to the clients first packet, saying who +// -- add some sort of vhost field to the client's first packet, saying who // they expect to talk to +// -- connection teardown is flawed: +// -- simple bug: often connections "fail" even though they succeeded. +// should figure out why. (Possibly one side doesn't wait for their +// goodbye packet to drain before closing the socket?) +// -- subtle misdesign: "goodbye" packets indicate completion of data +// transfer. they do not indicate that data has been written to +// disk. there should be some way to indicate that data has been +// successfully written to disk. See message (and thread) +// on +// monotone-devel. // // this is the "new" network synchronization (netsync) system in