# # # patch "HACKING" # from [c30170f75719369e7d173333c2d19df050016754] # to [7058afa41b4a62f2c04b67fd846b413de0ba182d] # # patch "tests/README" # from [ccb7c4ae3649d32872d2c6f7db03ef6bec2ba254] # to [a8afa6b4c99c7b1fe17721b6c8ecdb3062b60e6a] # # patch "testsuite.at" # from [bdc90ade96c294f4b14b061e1e6d0adbf002f60c] # to [7eb046ec5e8c90996e72969051e77e2a9be82e0e] # ============================================================ --- HACKING c30170f75719369e7d173333c2d19df050016754 +++ HACKING 7058afa41b4a62f2c04b67fd846b413de0ba182d @@ -115,13 +115,7 @@ test case exists, it is strongly recommended to write a test case before attempting to fix the bug. -When looking at test results or debugging tests, don't immediately panic if you -notice monotone processes being killed by a SIGSEGV. We use SIGSEGV to -terminate 'monotone serve' processes (only) to ensure the error exit paths are -tested. Other than these 'monotone serve' processes, any SIGSEGVs occurring -during the tests is very likely a bug. - Reporting errors to the user ---------------------------- ============================================================ --- tests/README ccb7c4ae3649d32872d2c6f7db03ef6bec2ba254 +++ tests/README a8afa6b4c99c7b1fe17721b6c8ecdb3062b60e6a @@ -14,8 +14,6 @@ - option -v will show the command outputs - option -d will keep the testsuite.dir files for post-test debugging - option -h is your friend :) -- don't panic if you see 'monotone serve' processes terminating with a SIGSEGV - during tests--we kill server processes with a SIGSEGV to get better code coverage. Creating tests: --------------- ============================================================ --- testsuite.at bdc90ade96c294f4b14b061e1e6d0adbf002f60c +++ testsuite.at 7eb046ec5e8c90996e72969051e77e2a9be82e0e @@ -367,11 +367,7 @@ ps | awk -- '{p=$NF;a=1;if(p=="COMMAND")next;pp=split(p,ps,"/");if(ps[[pp]]=="monotone")system("kill " $a);}' fi else - # use a SEGV because it will cause an exit, but trigger error - # unwind, so we will actually "exit normally"; which is important - # when using things like coverage tools, etc. that need to write out - # their data on program exit. - kill -SEGV $mt_pid 2>/dev/null + kill -TERM $mt_pid 2>/dev/null fi rm -f monotone_at.pid 2>/dev/null ])