monotone-commits-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-commits-diffs] Revision e3cde613358464300ab65e7b05637ef8473e4f


From: monotone
Subject: [Monotone-commits-diffs] Revision e3cde613358464300ab65e7b05637ef8473e4fc2
Date: Sun, 11 Feb 2007 19:05:22 +0100

-----------------------------------------------------------------
Revision: e3cde613358464300ab65e7b05637ef8473e4fc2
Ancestor: 6ec619835e1da8ef1499cf2ee8002b3e03ae0441
Author: address@hidden
Date: 2007-02-11T16:21:44
Branch: net.venge.monotone

Modified files:
        database.cc project.cc project.hh rev_height.cc
        rev_height.hh revision.hh schema_migration.cc

ChangeLog: 

        * rev_height.hh: Include <iosfwd>, not <iostream>.  Remove all
        using-declarations.  Remove all private member functions from
        class rev_height.  Move constructor bodies in here.  Replace
        from_string with explicit constructor taking a string.  Define
        new member function valid().  Remove unnecessary "inline" keywords.
        operator<< does not need to be a friend.
        * rev_height.cc: No need to include <iostream>, <string>, or
        numeric_vocab.hh.
        Constructors and operator() now live in class declaration.
        (operator <): Simplify.
        (read_at, write_at, append): Change from private
        members to plain static functions operating on strings.
        (size): Delete.
        (child_height, root_height): Update to match.  Return the result
        instead of writing it into a reference argument.
        * database.cc (get_rev_height): Adjust for change to
        rev_height::root_height. Call height.valid() before returning.
        (put_rev_height): Call valid() before inserting.
        (put_rev_height_for_revision): Adjust for change to
        rev_height::child_height.

        * revision.hh: Use std::string, not string.
        * project.hh: Include <string> and use std::string, not string.
        * project.cc, schema_migration.cc: Add using-declaration for
        std::string.

Attachment: txt7wSiy4ZHcC.txt
Description: Diff [6ec619835e1da8ef1499cf2ee8002b3e03ae0441] -> [e3cde613358464300ab65e7b05637ef8473e4fc2]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]