monotone-commits-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-commits-diffs] Revision d16bf75ad999c58ebecc993f563796e8e8e78a


From: monotone
Subject: [Monotone-commits-diffs] Revision d16bf75ad999c58ebecc993f563796e8e8e78aec
Date: Sat, 29 Sep 2007 17:05:31 +0200

-----------------------------------------------------------------
Revision: d16bf75ad999c58ebecc993f563796e8e8e78aec
Ancestor: 628766e4569d6eae5c74845b1b085c93c8e38f8e
Author: address@hidden
Date: 2007-09-29T05:11:00
Branch: net.venge.monotone.deregexp

Modified files:
        automate.cc cert.cc cmd_list.cc cmd_netsync.cc database.cc
        database.hh globish.cc globish.hh key_store.cc key_store.hh
        lua.cc lua_hooks.cc lua_hooks.hh luaext_globish.cc netcmd.cc
        netcmd.hh project.cc vocab_terms.hh

ChangeLog: 

* globish.cc: Complete rewrite.  No longer uses regular expressions.
Add lots more unit tests (still a bit sparse on the matching side).
* globish.hh: Document the syntax more precisely.  In particular,
character classes have been supported for ages, contra the comments.
(globish): Define here.  Is now a live object with a .matches()
method and a bunch of useful constructors.
(combine_and_check_globish): Replaced by globish constructors.
(globish_matcher): Is now just a thin convenience wrapper around
globish::matches.
* vocab_terms.hh (globish): Don't define here.

* database.cc: Include globish.hh.
(get_key_ids): Define as two overloads, one that unconditionally
returns all entries in the table, one that returns only those that
match a glob pattern.  Do not use SQLite GLOB for this.  Pattern
is passed in as a globish object, not a string.
(get_branches): Similarly.
* database.hh: Update to match.
* key_store.cc (get_keys): Rename as 1-argument overload of get_key_ids.
(get_key_ids): 2-argument form now takes a globish, not a string.
No need for globish_matcher.
* key_store.hh: Update to match.

* automate.cc (automate tags): No need for globish_matcher.
* cmd_list.cc (list keys): Change 'pattern' variable to a globish.
(list branches): Initialize exc directly from app.opts.exclude_patterns.
No need for globish_matcher.
(automate keys): Remove dummy first argument from calls to
db.get_key_ids and keys.get_key_ids.
* cert.cc (get_user_key): Use keys.get_key_ids.
* cmd_netsync.cc (extract_patterns): Simpler way to initialize
include_pattern and exclude_pattern now.
(clone): Similarly.
* lua.cc (record_if_matches): No need for globish_matcher.
* lua_hooks.cc: Include globish.hh.
* lua_hooks.hh: Forward-declare struct globish.
* luaext_globish.cc: No need for globish_matcher.  No need to catch
boost::bad_pattern.
* netcmd.cc: Include globish.hh.  Adjust unit tests -- globish does not
provide an == method.
* netcmd.hh: Forward-declare struct globish.
* project.cc (get_branch_list): Adjust call to db.get_branches.

Attachment: txtqTygKtdeZi.txt
Description: Diff [628766e4569d6eae5c74845b1b085c93c8e38f8e] -> [d16bf75ad999c58ebecc993f563796e8e8e78aec]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]