# # # patch "src/model/Branches.cpp" # from [6a240a83de4e8cf7aaf21467ba9b4205e586e487] # to [f6fb7124bbf93aafb16a8b3ce3fe161c2e06f8ea] # # patch "src/model/ChangesetModel.h" # from [a507c12b8b88b4fc546c157d15a087faa0ff3c5b] # to [0b931964cf31339db57d2215bd8cca916a3e0a3b] # # patch "src/model/ContentDiff.cpp" # from [35d7dcc334afc2c001d65aa230a17e3ea42986a3] # to [b9b75d298806aace824aae2e1e54239785b21218] # # patch "src/model/GetAttributes.cpp" # from [bd51d4f673480a28c18b78bf4290a4a5e0897589] # to [dc6c51679ca31a631a45b94ef634cd3db5be4ac3] # # patch "src/model/GetContentChanged.cpp" # from [784b1572425d9af21934de417f6cbc65db3419f3] # to [0c531336daa091157734aa87fb39859877c0e9d2] # # patch "src/model/GetRevision.cpp" # from [05616bd0029064d713e9a5e548aa73280fb06973] # to [0306aaaaa58093f4c4765f8a966fce0873120bbf] # # patch "src/model/GetRevision.h" # from [bb95945312477573c0d9f3e59cccb444df7e6328] # to [8f8b5b334bc0fdaadad441f82ed65024617ea8b1] # # patch "src/model/Inventory.cpp" # from [7056e6451d09ab9dbb5793d2b9529a5fddff9420] # to [5c2141e6a83a9f0ed4a7e32f60aff0bc2bb983f8] # # patch "src/model/InventoryItem.cpp" # from [c9df0dc20579742325d9ecff27ef0cbaf00a42ec] # to [2408e0c8d9b39e91e1815612bdafac74021ba762] # # patch "src/model/InventoryWatcher.cpp" # from [06eba8a6db3e127b2e8c32cc20e02e64953d8249] # to [b629ad57dc862ea587684bafaf11050ed8f5cf77] # # patch "src/monotone/MonotoneManager.cpp" # from [74729c467483726a250ad7428e49216df370d995] # to [1174b802e8c4bda9422032ee5abd6b2b97626e66] # # patch "src/monotone/MonotoneUtil.cpp" # from [1e21ab79a5d485224d25e9764623c5011840cc8e] # to [187a0a485688e4154ccd36cae9047fdc32696e58] # # patch "src/util/BasicIOWriter.cpp" # from [d2f3432143d8da08951f65c427a5f326666df211] # to [dfbc59fdce3e7d674e9f36bb9a7f25fa2a24bcf4] # # patch "src/util/TreeBuilder.cpp" # from [20cfbde5428b12a8f9d89bec6a39117dcf56c7e4] # to [0e65c5a08084e12989c4e1d6b4a012dc4fbeee8e] # # patch "src/view/InventoryView.cpp" # from [459a7ffa747b6a863200677a97ae897fbc808ede] # to [acf136cdfe5e8e591de5d50ec4fad199e4caf644] # # patch "src/view/dialogs/FileDiff.cpp" # from [265a8e82b7aa238024998afdbac19cc1dd41c0bb] # to [6e8ff5dbbb84e9fba38d899f7ed619169bd03cd3] # # patch "src/view/dialogs/UnaccountedRenames.cpp" # from [12bf5ca4c6cc7a2428514e9324e672f74abe1271] # to [f5c3cd56910a325ab9e0a2bb74140823985d15cd] # ============================================================ --- src/model/Branches.cpp 6a240a83de4e8cf7aaf21467ba9b4205e586e487 +++ src/model/Branches.cpp f6fb7124bbf93aafb16a8b3ce3fe161c2e06f8ea @@ -79,7 +79,7 @@ void Branches::processTaskResult(const M { QStringList branchList = task.getDecodedOutput() .split("\n", QString::SkipEmptyParts); - foreach (QString branch, branchList) + foreach (const QString & branch, branchList) { QStandardItem * item = new QStandardItem(); item->setData(branch, Qt::DisplayRole); ============================================================ --- src/model/ChangesetModel.h a507c12b8b88b4fc546c157d15a087faa0ff3c5b +++ src/model/ChangesetModel.h 0b931964cf31339db57d2215bd8cca916a3e0a3b @@ -45,7 +45,7 @@ struct Changeset QString htmllog; bool inList = false; - foreach (QString line, lines) + foreach (const QString & line, lines) { if (line.isEmpty()) { ============================================================ --- src/model/ContentDiff.cpp 35d7dcc334afc2c001d65aa230a17e3ea42986a3 +++ src/model/ContentDiff.cpp b9b75d298806aace824aae2e1e54239785b21218 @@ -66,7 +66,7 @@ void ContentDiff::readDatabaseDiff(const } QStringList opts; - foreach (QString r, revs) + foreach (const QString & r, revs) { opts << "r" << r; } @@ -108,7 +108,7 @@ void ContentDiff::readWorkspaceDiff(cons } QStringList opts; - foreach (QString r, revs) + foreach (const QString & r, revs) { opts << "r" << r; } ============================================================ --- src/model/GetAttributes.cpp bd51d4f673480a28c18b78bf4290a4a5e0897589 +++ src/model/GetAttributes.cpp dc6c51679ca31a631a45b94ef634cd3db5be4ac3 @@ -295,7 +295,7 @@ bool GetAttributes::hasDroppableAttribut bool GetAttributes::hasDroppableAttributes() const { - foreach(Attribute attr, attributes) + foreach(const Attribute & attr, attributes) { if (attr.state != Attribute::Dropped) { ============================================================ --- src/model/GetContentChanged.cpp 784b1572425d9af21934de417f6cbc65db3419f3 +++ src/model/GetContentChanged.cpp 0c531336daa091157734aa87fb39859877c0e9d2 @@ -125,7 +125,7 @@ void GetContentChanged::processTaskResul '\n', QString::SkipEmptyParts ); - foreach (QString par, parents) + foreach (const QString & par, parents) { // if we checked this revision already, skip it if (pathInRevision.contains(par)) @@ -147,7 +147,7 @@ void GetContentChanged::processTaskResul BasicIOParser parser(output); I(parser.parse()); StanzaList stanzas = parser.getStanzas(); - foreach (Stanza st, stanzas) + foreach (const Stanza & st, stanzas) { I(st.size() == 1); QString rev = st.at(0).hash; ============================================================ --- src/model/GetRevision.cpp 05616bd0029064d713e9a5e548aa73280fb06973 +++ src/model/GetRevision.cpp 0306aaaaa58093f4c4765f8a966fce0873120bbf @@ -305,7 +305,7 @@ QMap > { QList changes = revision.changesAgainstParent.value(currentParentRevision); - foreach (Change ch, changes) + foreach (const Change & ch, changes) { Stanza st = ch.stanza; QString path; @@ -313,7 +313,7 @@ QMap > bool isPatch = false; bool isAdd = false; - foreach (StanzaEntry en, st) + foreach (const StanzaEntry & en, st) { if (en.sym == "add_file") { @@ -373,7 +373,7 @@ QStringList GetRevision::getPathsForComp while (it.hasNext()) { it.next(); - foreach (Change ch, it.value()) + foreach (const Change & ch, it.value()) { QStringList fullPaths; switch (ch.type) @@ -391,7 +391,7 @@ QStringList GetRevision::getPathsForComp break; } - foreach (QString path, fullPaths) + foreach (const QString & path, fullPaths) { if (path.isEmpty()) continue; paths.insert(path); ============================================================ --- src/model/GetRevision.h bb95945312477573c0d9f3e59cccb444df7e6328 +++ src/model/GetRevision.h 8f8b5b334bc0fdaadad441f82ed65024617ea8b1 @@ -134,7 +134,7 @@ struct Revision revst.append(revision), list.append(revst); - foreach (Change ch, it.value()) + foreach (const Change & ch, it.value()) { list.append(ch.stanza); } ============================================================ --- src/model/Inventory.cpp 7056e6451d09ab9dbb5793d2b9529a5fddff9420 +++ src/model/Inventory.cpp 5c2141e6a83a9f0ed4a7e32f60aff0bc2bb983f8 @@ -174,7 +174,7 @@ void Inventory::processTaskResult(const // QMap > parentChildRelations; QMap tempItemMap; - foreach (Stanza st, stanzas) + foreach (const Stanza & st, stanzas) { InventoryItem * item = new InventoryItem(st); ============================================================ --- src/model/InventoryItem.cpp c9df0dc20579742325d9ecff27ef0cbaf00a42ec +++ src/model/InventoryItem.cpp 2408e0c8d9b39e91e1815612bdafac74021ba762 @@ -175,7 +175,7 @@ InventoryItem::InventoryItem(const Stanz : ModelItem(), fs_type(Undefined), old_type(Undefined), new_type(Undefined), status(0), expanded(false), aboutToBeExpanded(false) { - foreach (StanzaEntry en, stanza) + foreach (const StanzaEntry & en, stanza) { if (en.sym == "path") { @@ -239,7 +239,7 @@ InventoryItem::InventoryItem(const Stanz if (en.sym == "status") { I(en.vals.size() > 0); - foreach (QString val, en.vals) + foreach (const QString & val, en.vals) { if (val == "rename_source") status |= RenameSource; @@ -267,7 +267,7 @@ InventoryItem::InventoryItem(const Stanz if (en.sym == "changes") { I(en.vals.size() > 0 && en.vals.size() < 3); - foreach (QString val, en.vals) + foreach (const QString & val, en.vals) { if (val == "content") status |= ContentsChanged; ============================================================ --- src/model/InventoryWatcher.cpp 06eba8a6db3e127b2e8c32cc20e02e64953d8249 +++ src/model/InventoryWatcher.cpp b629ad57dc862ea587684bafaf11050ed8f5cf77 @@ -62,7 +62,7 @@ void InventoryWatcher::watchPaths(const { QStringList watchedPaths = files() + directories(); - foreach (QString path, paths) + foreach (const QString & path, paths) { QString fullPath(workspace); if (!path.isEmpty()) fullPath += "/" + path; @@ -75,7 +75,7 @@ void InventoryWatcher::unwatchPaths(cons { QStringList watchedPaths = files() + directories(); - foreach (QString path, paths) + foreach (const QString & path, paths) { QString fullPath(workspace); if (!path.isEmpty()) fullPath += "/" + path; @@ -120,7 +120,7 @@ void InventoryWatcher::checkForBookkeepC QStringList notifiedPaths; - foreach (Stanza newStanza, newRevisionEntries) + foreach (const Stanza & newStanza, newRevisionEntries) { QString newEntryType = newStanza.at(0).sym; // we don't care about patches, since we're notified of them @@ -208,7 +208,7 @@ void InventoryWatcher::checkForBookkeepC if (foundOrAlreadyHandled) continue; QString path = newStanza.at(0).vals.at(0); - foreach (QString handledPath, notifiedPaths) + foreach (const QString & handledPath, notifiedPaths) { if (path.indexOf(handledPath + "/") != -1) { @@ -225,12 +225,12 @@ void InventoryWatcher::checkForBookkeepC // now loop through all the left old items; // we should only have a subset of items in this list now - foreach (Stanza oldStanza, oldRevisionEntries) + foreach (const Stanza & oldStanza, oldRevisionEntries) { QString path = oldStanza.at(0).vals.at(0); bool alreadyNotified = false; - foreach (QString handledPath, notifiedPaths) + foreach (const QString & handledPath, notifiedPaths) { if (path.indexOf(handledPath + "/")) { ============================================================ --- src/monotone/MonotoneManager.cpp 74729c467483726a250ad7428e49216df370d995 +++ src/monotone/MonotoneManager.cpp 1174b802e8c4bda9422032ee5abd6b2b97626e66 @@ -227,7 +227,7 @@ DatabaseFile MonotoneManager::getDatabas Stanza st = stanzas.at(0); DatabaseFile databaseFilePath; - foreach (StanzaEntry entry, st) + foreach (const StanzaEntry & entry, st) { if (entry.sym == "database") { ============================================================ --- src/monotone/MonotoneUtil.cpp 1e21ab79a5d485224d25e9764623c5011840cc8e +++ src/monotone/MonotoneUtil.cpp 187a0a485688e4154ccd36cae9047fdc32696e58 @@ -204,11 +204,11 @@ RevisionCerts MonotoneUtil::getRevisionC RevisionCerts certs; StanzaList stanzas = parser.getStanzas(); - foreach (Stanza st, stanzas) + foreach (const Stanza & st, stanzas) { RevisionCert cert; - foreach (StanzaEntry en, st) + foreach (const StanzaEntry & en, st) { if (en.sym == "name") { @@ -249,12 +249,12 @@ FileEntryList MonotoneUtil::getRevisionM // FIXME: this should go into a separate function / class FileEntryList entries; StanzaList stanzas = parser.getStanzas(); - foreach (Stanza st, stanzas) + foreach (const Stanza & st, stanzas) { FileEntry entry; bool is_item = false; - foreach (StanzaEntry en, st) + foreach (const StanzaEntry & en, st) { if (en.sym == "format_version") { @@ -311,10 +311,10 @@ QStringList MonotoneUtil::getPrivateKeyL QStringList keys; StanzaList stanzas = parser.getStanzas(); - foreach (Stanza st, stanzas) + foreach (const Stanza & st, stanzas) { QString lastKey; - foreach (StanzaEntry en, st) + foreach (const StanzaEntry & en, st) { if (en.sym == "name") { @@ -388,7 +388,7 @@ bool MonotoneUtil::getAttribute(const Wo I(parser.parse()); StanzaList stanzas = parser.getStanzas(); - foreach (Stanza st, stanzas) + foreach (const Stanza & st, stanzas) { if (st.at(0).sym != "attr") continue; if (st.at(0).vals.at(0) == attrname) @@ -407,7 +407,7 @@ bool MonotoneUtil::getAttribute(const Da { FileEntryList entryList = getRevisionManifest(db, revision); - foreach (FileEntry en, entryList) + foreach (const FileEntry & en, entryList) { if (en.path != path) continue; if (en.attrs.contains(attrname)) ============================================================ --- src/util/BasicIOWriter.cpp d2f3432143d8da08951f65c427a5f326666df211 +++ src/util/BasicIOWriter.cpp dfbc59fdce3e7d674e9f36bb9a7f25fa2a24bcf4 @@ -25,7 +25,7 @@ QString BasicIOWriter::write() QString BasicIOWriter::write() { QString out; - foreach (Stanza st, stanzas) + foreach (const Stanza & st, stanzas) { out.append(writeStanza(st)); } @@ -35,7 +35,7 @@ QString BasicIOWriter::writeStanza(const QString BasicIOWriter::writeStanza(const Stanza & stanza) { QString out; - foreach (StanzaEntry en, stanza) + foreach (const StanzaEntry & en, stanza) { // ensure that not both, a hash and a value list, are given I(!(!en.hash.isNull() && en.vals.size() > 0)); @@ -61,7 +61,7 @@ QString BasicIOWriter::writeValueLine(co QString BasicIOWriter::writeValueLine(const StanzaEntry & entry) { QString vals; - foreach (QString val, entry.vals) + foreach (const QString & val, entry.vals) { vals.append(QString(" \"%1\"").arg(escape(val))); } ============================================================ --- src/util/TreeBuilder.cpp 20cfbde5428b12a8f9d89bec6a39117dcf56c7e4 +++ src/util/TreeBuilder.cpp 0e65c5a08084e12989c4e1d6b4a012dc4fbeee8e @@ -148,7 +148,7 @@ void TreeBuilder::addList(const QString { QStringList branchList = branches.split("\n", QString::SkipEmptyParts); - foreach (QString branch, branchList) + foreach (const QString & branch, branchList) { add(branch); } ============================================================ --- src/view/InventoryView.cpp 459a7ffa747b6a863200677a97ae897fbc808ede +++ src/view/InventoryView.cpp acf136cdfe5e8e591de5d50ec4fad199e4caf644 @@ -444,12 +444,12 @@ void InventoryView::slotContextMenuReque QMap actionCounter; - foreach (QString action, actions) + foreach (const QString & action, actions) { actionCounter.insert(action, 0); } - foreach (QModelIndex index, indexList) + foreach (const QModelIndex & index, indexList) { item = modelItem(sourceIndex(index)); invitem = dynamic_cast(item); @@ -851,7 +851,7 @@ QSet InventoryView::g return items; } - foreach (QModelIndex index, list) + foreach (const QModelIndex & index, list) { items.insert(modelItem(sourceIndex(index))); } ============================================================ --- src/view/dialogs/FileDiff.cpp 265a8e82b7aa238024998afdbac19cc1dd41c0bb +++ src/view/dialogs/FileDiff.cpp 6e8ff5dbbb84e9fba38d899f7ed619169bd03cd3 @@ -89,7 +89,7 @@ FileDiff::FileDiff(QWidget * parent) QSet codecNameSet; // eliminate aliases - foreach (QByteArray codec, codecNamesAndAliases) + foreach (const QByteArray & codec, codecNamesAndAliases) { codecNameSet.insert(QTextCodec::codecForName(codec)->name()); } @@ -97,7 +97,7 @@ FileDiff::FileDiff(QWidget * parent) ByteArrayList codecNames = codecNameSet.toList(); qSort(codecNames); - foreach (QByteArray codec, codecNames) + foreach (const QByteArray & codec, codecNames) { //! FIXME: better ordering, i.e. popular ones on top textEncoding->addItem(QString(codec)); ============================================================ --- src/view/dialogs/UnaccountedRenames.cpp 12bf5ca4c6cc7a2428514e9324e672f74abe1271 +++ src/view/dialogs/UnaccountedRenames.cpp f5c3cd56910a325ab9e0a2bb74140823985d15cd @@ -111,7 +111,7 @@ void UnaccountedRenames::findUnaccounted source->setText(1, sen.fileid.isEmpty() ? tr("n/a") : sen.fileid); source->setFont(1, boldFont); - foreach (FileEntry en, list) + foreach (const FileEntry & en, list) { QTreeWidgetItem * target = new QTreeWidgetItem(source); target->setFlags(Qt::ItemIsEnabled | Qt::ItemIsUserCheckable);