monotone-commits-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-commits-diffs] net.venge.monotone: f4d9a9a65688dbe7f3a0e074ed


From: code
Subject: [Monotone-commits-diffs] net.venge.monotone: f4d9a9a65688dbe7f3a0e074edb38db5308db221
Date: Thu, 25 Nov 2010 21:13:35 GMT

revision:            f4d9a9a65688dbe7f3a0e074edb38db5308db221
date:                2010-11-25T21:12:05
author:              Richard Levitte <address@hidden>
branch:              net.venge.monotone
changelog:
Disable the test that looks for tildes anywhere in a tilde-expanded
path, as tildes can exist in any directory name (and I happened to see
this test fail because I was running it in a directory that contained
a tilde).
Either way, a test to find a tilde anywhere is pretty unnecessary, as
the test before showed that *something* happened, which is the
requirement anyway, judging from the comment higher up.


manifest:
format_version "1"

new_manifest [f454435bdb07de6657f9cbbdd0e7fb066c6cbe16]

old_revision [37610c8e8486e1ff2369f6d8a35c1dbe9ffbd028]

patch "unit-tests/paths.cc"
 from [f443111b016125fb2b00af638586853a68369ad9]
   to [13dfa659d5004f26fb85b285990378ccd7a180ac]
============================================================
--- unit-tests/paths.cc	f443111b016125fb2b00af638586853a68369ad9
+++ unit-tests/paths.cc	13dfa659d5004f26fb85b285990378ccd7a180ac
@@ -634,7 +634,11 @@ UNIT_TEST(system)
 #else
   UNIT_TEST_CHECK(tilde_expanded[0] == '/');
 #endif
-  UNIT_TEST_CHECK(tilde_expanded.find('~') == string::npos);
+  // This test should not be performed, tildes are allowed in the middle
+  // of paths, and we have already shown in the previous test that what
+  // we expected happened (or didn't).
+  //UNIT_TEST_CHECK(tilde_expanded.find('~') == string::npos);
+
   // on Windows, ~name is not expanded
 #ifdef WIN32
   UNIT_TEST_CHECK(system_path("~this_user_does_not_exist_anywhere")

reply via email to

[Prev in Thread] Current Thread [Next in Thread]