[Monotone-commits-diffs] net.venge.monotone: 03eab89789562e6056b6bfb721615023472938a2

[code]

revision:            03eab89789562e6056b6bfb721615023472938a2
date:                2011-01-23T11:48:48
author:              Richard Hopkins
branch:              net.venge.monotone
changelog:
Always print include/exclude patterns during a netsync operation

This is to inform the user which patterns are being used for the following
reasons

-> They could not specify any patterns explicitly on the command line making
any defaults in the db be used instead. As we print out "connecting to ..."
which could also be a default, this change helps the user also know what the
patterns are.

-> They could specify the patterns on the command line, and believe they
specified a pattern which is not actually being used. For instance, exclude
patterns require ;-, so the user enters

mtn pull mtn://myhost.com?myproject?good_branch;-bad_branch

However, this would actually do
connecting to mtn://myhost.com
        with include pattern = good_branch
        with exclude pattern = <blank>

then the terminal may throw an error after the netsync operation, as some
terminals require the ; be entered with \;. However, the user may believe
the pull succeeded and there is different error when we do not print the
patterns.

Us printing out the patterns here helps the user know exactly what has been
extracted from his URI, as not everyone knows or remembers to type \ when it
is needed.

The correct entry should be

mtn pull mtn://myhost.com?myproject?good_branch\;-bad_branch

-> I believe get_netsync_connect_command can also be used to specify patterns
so we should print them if they do not enter them on the command line.

applied changes from a92afea09d497594da69317ef9c661807ef38b2a
             through 9f4f219ea85d2f27ea603c8fd54d7928991ddbe7

manifest:
format_version "1"

new_manifest [b139290f68c26cf9649a96bdc692e972440f0f59]

old_revision [d7328eed17ce4799373f25d19e182f154fad303e]

patch "netsync.cc"
 from [23b3d65718b94c552bcbb12beb74b3a44f0c8b5e]
   to [bda5adcae7b66d8c3195a4eceae052a225219a17]
============================================================
--- netsync.cc	23b3d65718b94c552bcbb12beb74b3a44f0c8b5e
+++ netsync.cc	bda5adcae7b66d8c3195a4eceae052a225219a17
@@ -110,6 +110,8 @@ call_server(app_state & app,
     instant(0,1);
 
   P(F("connecting to %s") % info->client.get_uri().resource());
+  P(F("  include pattern  %s") % info->client.get_include_pattern());
+  P(F("  exclude pattern  %s") % info->client.get_exclude_pattern());
 
   shared_ptr<Netxx::StreamBase> server
     = build_stream_to_server(app.opts, app.lua, info, timeout);