[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-devel] Re: .mt-attrs formatting
From: |
Bruce Stephens |
Subject: |
[Monotone-devel] Re: .mt-attrs formatting |
Date: |
Thu, 19 Aug 2004 19:22:20 +0100 |
User-agent: |
Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) |
Richard Levitte - VMS Whacker <address@hidden> writes:
[...]
> Do you have a possibility to check that I haven't forgotten
> anything? I'm quite short on time, so I haven't made any tests.
The code's obviously correct, as far as it goes. I don't know whether
there's anything else which reads .mt-attrs, but I'd guess not. It
worked on the one example I tried, so essentially it works. It's
probably worth changing the test, too:
--- tests/t_attributes.at
+++ tests/t_attributes.at
@@ -10,7 +10,7 @@
AT_DATA(a, [some data
])
AT_DATA(.mt-attrs,
-[test_attr true foo
+[test_attr true foo
test_attr 1 a
])
I verified that this fails before your change, and succeeds afterwards.
I considered reworking the code to allow comments, and to warn when
the regexp doesn't match, but it's probably not worth it. 99% of the
time this'll be used to make configure, autogen.sh, and similar files
executable, and the right solution for the rest is to use lua to parse
the file, not C++.
- [Monotone-devel] .mt-attrs formatting, Bruce Stephens, 2004/08/19
- Re: [Monotone-devel] .mt-attrs formatting, Richard Levitte - VMS Whacker, 2004/08/19
- [Monotone-devel] Re: .mt-attrs formatting,
Bruce Stephens <=
- [Monotone-devel] Re: .mt-attrs formatting, graydon hoare, 2004/08/19
- Re: [Monotone-devel] Re: .mt-attrs formatting, Richard Levitte - VMS Whacker, 2004/08/19
- Re: [Monotone-devel] Re: .mt-attrs formatting, graydon hoare, 2004/08/19
- Re: [Monotone-devel] Re: .mt-attrs formatting, Kevin Smith, 2004/08/19
- Re: [Monotone-devel] Re: .mt-attrs formatting, Richard Levitte - VMS Whacker, 2004/08/19
- Re: [Monotone-devel] Re: .mt-attrs formatting, Jon Bright, 2004/08/20
- Re: [Monotone-devel] Re: .mt-attrs formatting, Phil de Joux, 2004/08/20
- Re: [Monotone-devel] Re: .mt-attrs formatting, Richard Levitte - VMS Whacker, 2004/08/19
- [Monotone-devel] Re: .mt-attrs formatting, Bruce Stephens, 2004/08/19
- [Monotone-devel] Re: .mt-attrs formatting, graydon hoare, 2004/08/19