[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] package_revision.txt getting "unknown" when it shou
From: |
Nathaniel Smith |
Subject: |
Re: [Monotone-devel] package_revision.txt getting "unknown" when it shouldn't? |
Date: |
Mon, 6 Dec 2004 13:13:13 -0800 |
User-agent: |
Mutt/1.5.6+20040907i |
On Mon, Dec 06, 2004 at 09:48:12PM +0100, Richard Levitte - VMS Whacker wrote:
> I noticed the addition of package_revision.txt, and thought that was a
> great idea, and was at the same time a bit disappointed at the way it
> was handled. I thought the idea would be that a distribution (made
> with "make dist", for example) would carry the revision information
> with it, so a compile outside of a monotone work directory would still
> be identified with information about the place in history it comes
> from.
Sure.
> The attached change does that. If noone complains, I'll commit it
> tomorrow evening.
Only problem I see is that I'd like some extra message written into
the --full-version if we were unable to regenerate it at build time;
right now it can't possibly be stale information (unless someone is
editing files _while_ building), but in principle someone could
download a distribution, make some local changes, build it, and
--full-version would show no sign.
Also, some comment on what's going on in those build rules would be
nice, it took me some puzzling to figure it out :-).
-- Nathaniel
--
"But in Middle-earth, the distinct accusative case disappeared from
the speech of the Noldor (such things happen when you are busy
fighting Orcs, Balrogs, and Dragons)."