[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/
From: |
Christof Petig |
Subject: |
Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch |
Date: |
Mon, 23 Jan 2006 10:21:17 +0100 |
User-agent: |
Mail/News 1.5 (X11/20060119) |
Vinzenz 'evilissimo' Feenstra wrote:
> I've tested the modifications now and corrected them. The source
> compiles fine now.
> So this should be the final diff for it :)
What a mess ...
If I compare the patch to the subject of this thread I feel a bit sick.
While Nathaniel stated that std::string, CoW and % are ok with him, you
rewrote your patch to use non-typesafe VA_ARGS using execute/fetch
variants. I hope that you did not invest too much time into this
modifications.
I really liked to be able to remove .c_str() from the query parameter on
several calls because I dumped VA_ARGS.
And this misunderstanding/debate actually prevents sqlite3.binary from
being included IIRC.
Sigh
Christof
I would vote for your original % (and std::string ?) based approach.
Should I take the time and (ab)use your patches to my liking? Perhaps we
should sort this out first.
signature.asc
Description: OpenPGP digital signature
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, (continued)
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, Timothy Brownawell, 2006/01/21
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, Richard Levitte - VMS Whacker, 2006/01/21
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, Nathaniel Smith, 2006/01/22
- [Monotone-devel] Copy-on-write not mandated! (Was: Typesafe VA_ARGS replacement for database::execute/fetch), Clemens Hintze, 2006/01/22
- Re: [Monotone-devel] Copy-on-write not mandated! (Was: Typesafe VA_ARGS replacement for database::execute/fetch), Nathaniel Smith, 2006/01/22
- Re: [Monotone-devel] Copy-on-write not mandated! (Was: Typesafe VA_ARGS replacement for database::execute/fetch), Patrick Mauritz, 2006/01/23
- Re: [Monotone-devel] Copy-on-write not mandated!, Petr Ovtchenkov, 2006/01/24
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, Vinzenz 'evilissimo' Feenstra, 2006/01/21
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, Vinzenz 'evilissimo' Feenstra, 2006/01/21
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, Vinzenz 'evilissimo' Feenstra, 2006/01/21
- Re: [Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch,
Christof Petig <=
[Monotone-devel] Typesafe VA_ARGS replacement for database::execute/fetch, Vinzenz 'evilissimo' Feenstra, 2006/01/19