[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] [PATCH] Specifying multiple --message arguments for
From: |
Nathaniel Smith |
Subject: |
Re: [Monotone-devel] [PATCH] Specifying multiple --message arguments for commits |
Date: |
Tue, 3 Oct 2006 22:20:21 -0700 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Tue, Oct 03, 2006 at 09:40:02PM -0700, Evan Deaubl wrote:
> ============================================================
> --- tests/multiple_message_commit/__driver__.lua
> 7678a487298dc1340180abfd8a692f8684b5a527
> +++ tests/multiple_message_commit/__driver__.lua
> 7678a487298dc1340180abfd8a692f8684b5a527
> @@ -0,0 +1,5 @@
> +
> +mtn_setup()
> +
> +addfile("a", "hello there")
> +check(mtn("--debug", "commit", "--message", "line 1", "--message", "line
> 2"), 0, false, false)
This is the right way to do it, except you're still not testing that
the new functionality actually works :-). I'm pretty sure this test
would have succeeded without your patch, too, just it would have only
put "line 2" into the commit message...
Try calling "automate certs" on the base_revision, perhaps, maybe
adding --date to the commit command to make the output entirely
predictable (and thus easier to check for correctness)...
-- Nathaniel
--
Eternity is very long, especially towards the end.
-- Woody Allen