[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Repeatable 'monotone serve' crash
From: |
Thomas Moschny |
Subject: |
Re: [Monotone-devel] Repeatable 'monotone serve' crash |
Date: |
Fri, 5 Jan 2007 22:15:49 +0100 |
User-agent: |
KMail/1.9.5 |
On Friday 05 January 2007 21:40, Timothy Brownawell wrote:
> gdb tells me that the destination file is da39... , ie, the empty file.
Yeah, that's exactly what I found out by looking at Ethan's database and the
file_deltas therein.
> IIRC an xdelta consists of copy+insert instructions; to delete
> everything you leave the xdelta empty.
>
> An empty xdelta is not the same as an xdelta that does nothing. The
> invariant is based on a wrong assumption, and should be removed.
Or changed as to also check whether destination is empty.
- Thomas M.