|
From: | Zack Weinberg |
Subject: | Re: [Monotone-devel] Please review quickly [Fwd: [bug #19137] permissions on ~/.monotone/keys/ are too permissive] |
Date: | Sat, 28 Apr 2007 21:56:13 -0700 |
On 4/14/07, Zack Weinberg <address@hidden> wrote:
I'm going to suggest write_data_userprivate(), with the same interface as write_data(), implemented entirely in platform/, and (on Unix) using 3-argument open() so the file permissions are right from the moment it's created.
Implemented now and pushed as 81798740507c3414f4833a7451f9b559ca03a167, with tests even. The Windows code (all in win32/fs.cc) has not even been compiled, and does not attempt to do the equivalent of supplying mode 0600 to open() - it can be done, but it's way beyond my pain threshold. (It does give the user a nice friendly warning that the file is accessible to any user.) zw
[Prev in Thread] | Current Thread | [Next in Thread] |