[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Hooks...
From: |
Richard Levitte |
Subject: |
Re: [Monotone-devel] Hooks... |
Date: |
Wed, 05 Sep 2007 15:19:02 +0200 (CEST) |
In message <address@hidden> on Wed, 5 Sep 2007 13:54:23 +0100, Matthew Sackman
<address@hidden> said:
matthew> On Wed, Sep 05, 2007 at 02:47:52PM +0200, Richard Levitte wrote:
matthew> > We need to think a few steps further, me thinks:
matthew> >
matthew> > - What do we do with the values returned by the hook functions,
matthew> > especially if one event has more than one hook function registered?
matthew>
matthew> On registration you have a priority. Registration errors if
matthew> two functions are registered with the same priority. Result:
matthew> total ordering between registered hook functions.
OK.
matthew> Each hook can return one of three values: everything ok;
matthew> non-fatal error; fatal error.
Good. We need to decide how that should work, because nil doesn't
necessarely imply an error (let alone that it doesn't describe the
fatality of an error).
matthew> > - Do we want a third function that returns information
matthew> > about a hook, such as how many functions are attached and
matthew> > their identities (the id returned by add_hook()), and
matthew> > whatever other data there may be.
matthew>
matthew> How do imagine this to be used? I don't see the value of it
matthew> from the hook's perspective, and whilst it could be valueable
matthew> to a user, if the user doesn't know what hooks they have
matthew> registered then they have other problems.
Right, and all users are always aware of what is in /etc/monotonerc...
Cheers,
Richard
-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.
--
Richard Levitte address@hidden
http://richard.levitte.org/
"When I became a man I put away childish things, including
the fear of childishness and the desire to be very grown up."
-- C.S. Lewis
- [Monotone-devel] Hooks..., Richard Levitte, 2007/09/05
- Re: [Monotone-devel] Hooks..., Nathaniel Smith, 2007/09/05
- Re: [Monotone-devel] Hooks..., Richard Levitte, 2007/09/05
- Re: [Monotone-devel] Hooks..., Nathaniel Smith, 2007/09/05
- Re: [Monotone-devel] Hooks..., Stephen Leake, 2007/09/05
- Re: [Monotone-devel] Hooks..., Alex Queiroz, 2007/09/06