nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] state flag related modifications


From: Benno Schulenberg
Subject: Re: [PATCH] state flag related modifications
Date: Mon, 21 Dec 2020 17:39:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

Op 21-12-2020 om 07:16 schreef ObeliX:
> Subject: [PATCH] fix: set/unset a mark by mouse doubleclick, did not update
>  the state flags

When you find a bug, please report it on Savannah.  I have reported it here:

  https://savannah.gnu.org/bugs/?59747

>               /* Clicking where the cursor is toggles the mark, as does 
> clicking
>                * beyond the line length with the cursor at the end of the 
> line. */
> -             if (sameline && openfile->current_x == current_x_save)
> +             if (sameline && openfile->current_x == current_x_save) {
>                       do_mark();
> -             else
> +                     if (ISSET(STATEFLAGS)) titlebar(NULL);

The 'if' on a single line is not nano's style.  When changing the code,
please follow the style of the surrounding code.

The fix itself looks good, though.  Please provide a signed-off patch,
as the README.GIT file requests.

Benno

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]