[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Net::FTPServer] Re: Net::FTPServer Patch
From: |
Richard Jones |
Subject: |
[Net::FTPServer] Re: Net::FTPServer Patch |
Date: |
Sun, 8 Feb 2004 19:18:08 +0000 |
User-agent: |
Mutt/1.5.4i |
On Sun, Feb 08, 2004 at 10:57:10AM -0800, David Wheeler wrote:
> Richard,
>
> I tried out Net::FTPServer yesterday. Seems to work pretty well. I did
> run into a warning that you might want to fix. Here is the patch.
>
> -- FTPServer.old Sat Feb 7 17:49:27 2004
> +++ FTPServer.pm Sat Feb 7 17:49:10 2004
> @@ -3133,7 +3133,7 @@
>
> if ( my $log_file = $self->config("error log") ) {
> $log_file = $self->resolve_log_file_name($log_file) ;
> - if ( $log_file ne $self->{_error_file} ) {
> + if ( ! defined $self->{_error_file} || $log_file ne
> $self->{_error_file} ) {
> $self->log( 'notice', "Switch error log to $log_file") ;
> open STDERR, ">>$log_file"
> or die "cannot append: $log_file: $!";
>
> Are you running all of your tests with -w? That will help eliminate any
> other warnings.
>
> Also, I noticed when I tried to install Net::FTPServer via CPAN that
> all the tests failed. This was because BSD::Resource wasn't installed.
> I recommend you add this to Makefile.PL to prevent getting test failure
> reports sent to address@hidden:
>
> PREREQ_PM => { 'BSD::Resource' => 0 },
>
> Regards,
>
> David
>
Thanks David. I've put both of your fixes into CVS.
Rich.
--
Richard Jones. http://www.annexia.org/ http://www.j-london.com/
Merjis Ltd. http://www.merjis.com/ - improving website return on investment
Perl4Caml lets you use any Perl library in your type-safe Objective
CAML programs. http://www.merjis.com/developers/perl4caml/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Net::FTPServer] Re: Net::FTPServer Patch,
Richard Jones <=