[Nmh-commits] nmh ChangeLog mts/smtp/smtp.c

[David Levine]

CVSROOT:        /sources/nmh
Module name:    nmh
Changes by:     David Levine <levine>   09/12/21 17:18:04

Modified files:
        .              : ChangeLog 
        mts/smtp       : smtp.c 

Log message:
        * mts/smtp/smtp.c: In sm_auth_sasl (), removed zeroing of
        sasl_inbuffer because it could be used in sm_fget ().  Also,
        removed allocation of sasl_inbuffer because that was done in
        either smtp_init () or sendmail_init ().

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/nmh/ChangeLog?cvsroot=nmh&r1=1.304&r2=1.305
http://cvs.savannah.gnu.org/viewcvs/nmh/mts/smtp/smtp.c?cvsroot=nmh&r1=1.27&r2=1.28

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/nmh/nmh/ChangeLog,v
retrieving revision 1.304
retrieving revision 1.305
diff -u -b -r1.304 -r1.305
--- ChangeLog   18 Jan 2009 04:48:42 -0000      1.304
+++ ChangeLog   21 Dec 2009 17:18:04 -0000      1.305
@@ -1,3 +1,10 @@
+2009-12-21  David Levine <address@hidden>
+
+       * mts/smtp/smtp.c: In sm_auth_sasl (), removed zeroing of
+       sasl_inbuffer because it could be used in sm_fget ().  Also,
+       removed allocation of sasl_inbuffer because that was done in
+       either smtp_init () or sendmail_init ().
+
 2009-01-17  Eric Gillespie  <address@hidden>
 
        * etc/mhn.defaults.sh: Never try to make mhshow start xterm.

Index: mts/smtp/smtp.c
===================================================================
RCS file: /sources/nmh/nmh/mts/smtp/smtp.c,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -b -r1.27 -r1.28
--- mts/smtp/smtp.c     26 Jan 2009 13:38:13 -0000      1.27
+++ mts/smtp/smtp.c     21 Dec 2009 17:18:04 -0000      1.28
@@ -1,7 +1,7 @@
 /*
  * smtp.c -- nmh SMTP interface
  *
- * $Id: smtp.c,v 1.27 2009/01/26 13:38:13 bress Exp $
+ * $Id: smtp.c,v 1.28 2009/12/21 17:18:04 levine Exp $
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
@@ -903,20 +903,12 @@
                return NOTOK;
        }
        sasl_outbuflen = 0;
-
-       sasl_inbuffer = malloc(SASL_MAXRECVBUF);
-
-       if (sasl_inbuffer == NULL) {
-               sm_ierror("Unable to allocate %d bytes for SASL input "
-                         "buffer", SASL_MAXRECVBUF);
-               free(sasl_outbuffer);
-               return NOTOK;
-       }
        sasl_inbuflen = 0;
        sasl_inptr = sasl_inbuffer;
     } else {
        sasl_outbuffer = NULL;
-       sasl_inbuffer = NULL;
+        /* Don't NULL out sasl_inbuffer because it could be used in
+           sm_fgetc (). */
     }
 
     sasl_complete = 1;