[Octave-bug-tracker] [bug #36717] Fix curl_handle::curl_handle_rep to keep a copy of string parameters passed to cURL

[Mike Miller]

URL:
  <http://savannah.gnu.org/bugs/?36717>

                 Summary: Fix curl_handle::curl_handle_rep to keep a copy of
string parameters passed to cURL
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Sun 24 Jun 2012 12:56:22 PM EDT
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

The cURL library changed the curl_easy_setopt call to make an internal copy of
string parameters in version 7.17.0.  Prior versions only held a pointer to a
string provided by the caller that must persist for the lifetime of the CURL
handle.

The associated API did not change, only the behavior of the library
implementing the function call.

To be compatible with any version of cURL, the caller must keep a copy of all
string parameters associated with a CURL handle until the handle is released. 
The curl_handle::curl_handle_rep class contains the pointer to the CURL handle
and so is the best candidate for storing the strings as well.

Maybe implement this with a new macro

#define setstropt(option, parameter)


The string options affected are CURLOPT_URL (failure observed) and
CURLOPT_USERPWD (likely, not yet observed).




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36717>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/