Re: [Octave-bug-tracker] [bug #36732] interp1 does not check input for monotonicity

[Ben Abbott]

On Aug 17, 2012, at 3:13 AM, vivek dogra wrote:

> On Thu, Aug 16, 2012 at 5:45 PM, Ben Abbott <address@hidden> wrote:
> Follow-up Comment #7, bug #36732 (project octave):
> 
> Vivek
> 
> I'm currently not able to build Octave (hope to be doing so in a day or two,
> when I have time to work on that), so I'm not able to push your changeset yet
> (perhaps someone else will?).
> 
> In any event, I hope you'll continue to contribute to Octave.  Related to
> that, I see a few small violations of our coding standards.  There should be a
> space between function names and their parentheses. For example, "diff(x)"
> should be "diff (x)".
> 
> Other than that, the changeset looks good to me.
> 
>     _______________________________________________________
> 
> Reply to this item at:
> 
>   <http://savannah.gnu.org/bugs/?36732>
> 
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.gnu.org/
> 
> Hi Ben,
> Thanks for your reply. I will keep in mind coding standards from the next 
> time. Should i create new changeset for this now to correct it? 
> I am also looking forward to get involved actively with the development of 
> Octave. Considering it was my first open source involvement, i am really 
> happy :)
> 
> With regards,
> Vivek

The one you've submitted is sufficient.

Thanks
Ben