[Octave-bug-tracker] [bug #41612] pinv with tol fix for Diagonal Matrices

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?41612>

                 Summary: pinv with tol fix for Diagonal Matrices
                 Project: GNU Octave
            Submitted by: None
            Submitted on: Sun 16 Feb 2014 07:55:29 PM UTC
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

I just noticed a patch got sent to fix a bug I reported last week.

Awesome - thanks. However there's a small gotcha in the new code:

+      if (std::abs (elem (i, i)) < tol)
+        retval.elem (i, i) = 0.0;
+      else
         retval.elem (i, i) = 1.0 / elem (i, i);


When tol==0 and elem(i,i)==0, the code will divide by zero. Otherwise looks
good - sorry I couldn't find the original bug report so I had to re-post.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?41612>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/