[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or prov
From: |
Juan Pablo Carbajal |
Subject: |
[Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions |
Date: |
Mon, 17 Mar 2014 20:25:27 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.149 Safari/537.36 |
Follow-up Comment #3, bug #41796 (project octave):
Hi Max,
The changes look goo, just a few comments.
It will be awesome to have some inline comments on the parsing part of the
code. This can get big and ugly quite fast, so better keep it commented.
Also, it seems that the if on triangular is inverted, right? One should call
the triangular version of ind2sub and sibling when triangular is true.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?41796>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Juan Pablo Carbajal, 2014/03/06
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Massimiliano Fasi, 2014/03/08
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Massimiliano Fasi, 2014/03/08
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions,
Juan Pablo Carbajal <=
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Massimiliano Fasi, 2014/03/18
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Jordi Gutiérrez Hermoso, 2014/03/18
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Juan Pablo Carbajal, 2014/03/18
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Eduardo Ramos Fernández, 2014/03/19
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Eduardo Ramos Fernández, 2014/03/19
- [Octave-bug-tracker] [bug #41796] Generalize sub2ind and ind2sub or provide specialized functions, Massimiliano Fasi, 2014/03/19