|
From: | Guillaume |
Subject: | [Octave-bug-tracker] [bug #49559] Implementation of containers.Map |
Date: | Thu, 6 Apr 2017 08:45:04 -0400 (EDT) |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0 |
Follow-up Comment #18, bug #49559 (project octave): Thank you both for your inputs - it's very informative to look at the changes you've made. And the speed improvements are great. I attach a small patch to set ValueType to "any" if the values are not scalar. It also makes sure keys and values are row vectors as this property was lost with some of the changes. I also modified the "sort_keys" function to decode numeric keys before sorting as mentioned by Rik - I didn't want to do that earlier for performance reasons but it seems to be less of an issue now. Otherwise have a look at the end of comment #14 for a way to sort numeric keys with negative values correctly (ie take the negative of positive values and the 2-complement of negative values before calling sort). Thank you. (file #40291) _______________________________________________________ Additional Item Attachment: File name: fixmap.diff Size:2 KB _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?49559> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |