|
From: | Mike Miller |
Subject: | [Octave-bug-tracker] [bug #49053] figure scaling issue with Qt 5 on macOS with Retina / HiDPI scaling |
Date: | Thu, 18 Jan 2018 15:01:48 -0500 (EST) |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 |
Update of bug #49053 (project octave): Status: None => Patch Submitted _______________________________________________________ Follow-up Comment #41: Do you want someone to check that Octave builds with the patch, or do you also need someone with a HiDPI display to test the appearance on a GNU/Linux system with Qt 4 or 5? Some comments on the patch: * break lines longer than 80 columns * needs more spaces, e.g. between function name and parens, around all '*' operators * "QApplication.h" should be "QApplication" * we try to avoid version checks completely in Octave, if possible there should be a configure feature test for some function/class/method that is required for the conditional parts of this patch to work. Is devicePixelRatio the function that is only present in Qt 5? Is it the entire class QScreen? Those should be tested for in configure to produce a proper conditional. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?49053> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |