|
From: | Rik |
Subject: | [Octave-bug-tracker] [bug #55366] Second argument to save_binary is a non-constant reference |
Date: | Thu, 3 Jan 2019 00:25:29 -0500 (EST) |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko |
URL: <https://savannah.gnu.org/bugs/?55366> Summary: Second argument to save_binary is a non-constant reference Project: GNU Octave Submitted by: rik5 Submitted on: Wed 02 Jan 2019 09:25:24 PM PST Category: None Severity: 3 - Normal Priority: 5 - Normal Item Group: None Status: None Assigned to: None Originator Name: Originator Email: Open/Closed: Open Discussion Lock: Any Release: dev Operating System: Any _______________________________________________________ Details: The prototype for the function save_binary has a reference to bool (bool& save_as_floats) as the second function argument. It is very likely that this should either be a constant reference or the reference should be skipped entirely and it should just be a bool passed by value. This issue was identified by static analysis of the code. If this is indeed the case, then a whole bunch of function prototypes need to change starting with ov.h and proceeding in to each octave_value class. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?55366> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |