|
From: | Andrew Janke |
Subject: | [Octave-bug-tracker] [bug #54219] Dynamic detection of JVM on macOS |
Date: | Thu, 10 Jan 2019 23:35:41 -0500 (EST) |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36 |
Follow-up Comment #17, bug #54219 (project octave): > it seems you are moving the run_command_and_return_output function that is currently static in toplev.cc to a separate file and putting it in the octave::sys namespace. > > I don't see where you are removing the old function. No, run_command_and_return_output is a new function added in this patch; it's not moved from anywhere. Would it be easier to read if I condensed this into a single changeset? _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?54219> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |