[Octave-bug-tracker] [bug #57087] [instrument-control] tests fail on macOS for tcp/udp read/write

[Andrew Janke]

URL:
  <https://savannah.gnu.org/bugs/?57087>

                 Summary: [instrument-control] tests fail on macOS for tcp/udp
read/write
                 Project: GNU Octave
            Submitted by: apjanke
            Submitted on: Sun 20 Oct 2019 08:00:55 AM EDT
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Incorrect Result
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 4.4.1
        Operating System: Mac OS

    _______________________________________________________

Details:

On macOS 10.14.6, under Octave.app 4.4.1, the Octave Forge package
instrument-control will install for me, but has test failures in tcp/udp
read/write tests. It looks like the failures all happen when it's doing a
tcp_read or tcp_write, and in all cases the error is an "invalid argument"
error returned by select().


>> runtests2 -pkg instrument-control -log-file instrument-control_tests.txt
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/instrhwinfo.m  PASS     
4/4
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/seriallist.m  PASS     
1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/tcpip.m  PASS      1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/__instr_hwinfo__.cc-tst
 PASS      1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/__tcp_properties__.cc-tst
 PASS      6/6
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/__udp_properties__.cc-tst
 PASS      6/6
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/gpib.cc-tst  PASS  
   1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/i2c.cc-tst  PASS   
  1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/parallel.cc-tst 
PASS      1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/pp_close.cc-tst 
PASS      3/3
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/pp_ctrl.cc-tst 
PASS      2/2
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/pp_data.cc-tst 
PASS      2/2
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/pp_datadir.cc-tst 
PASS      2/2
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/pp_stat.cc-tst 
PASS      2/2
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/resolvehost.cc-tst 
PASS      7/7
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/serial.cc-tst  PASS
     1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp.cc-tst  PASS   
  3/3
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp_close.cc-tst 
PASS      3/3
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp_read.cc-tst 
PASS      2/3
                                                                FAIL      1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp_write.cc-tst 
PASS      2/3
                                                                FAIL      1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp.cc-tst  PASS   
  4/4
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_close.cc-tst 
PASS      3/3
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_read.cc-tst 
PASS      3/4
                                                                FAIL      1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_timeout.cc-tst 
PASS      3/3
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_write.cc-tst 
PASS      4/5
                                                                FAIL      1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/usbtmc.cc-tst  PASS
     1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/vxi11.cc-tst  PASS 
    1/1
  /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/udp_demo.m  PASS     
3/3

Summary:

  GNU Octave Version: 4.4.1 (hg id: 1f46d371968c + patches)
  Tests run on eilonwy.local (macOS) at 20-Oct-2019 04:39:38
  Test execution time: 00:00:09

  PASS                               73
  FAIL                                4

  Failed tests:
     /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp_read.cc-tst
     /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp_write.cc-tst
     /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_read.cc-tst
     /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_write.cc-tst


Test failure details:


>>>>> /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp_read.cc-tst
***** test block 1: test
  is_test=1 is_xtest=0
Code:
 addr = resolvehost ('gnu.org', 'address');
 a = tcp (addr, 80);
 assert (! isnull (a));
 # server should be waiting for us to send request
 fail ("tcp_read (a, 10, 0, 0)", "Invalid call to tcp_read");

 [d,c] = tcp_read (a, 1, 0);
 assert (0, c);
 assert (isempty (d));

 tic;
 [d,c] = tcp_read (a, 1, 1000);
 t = toc;
 assert (c, 0);
 assert (isempty (d));
 assert (t, 1.0, 0.1)

 tcp_close (a); 
--> success=0, msg=test failed: raised error: tcp_read: Error while
reading/select: 22 - Invalid argument

[...]

>>>>> /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/tcp_write.cc-tst
[...]
***** test block 3: test
  is_test=1 is_xtest=0
Code:
 addr = resolvehost ('gnu.org', 'address');
 a = tcp (addr, 80);;
 # call HTTP HEAD
 req = "HEAD / HTTP/1.1\r\n\r\n";
 assert (length (req), tcp_write (a, req));
 [d, c] = tcp_read (a, 12, 5000);
 tcp_close (a);
 assert (12, c);
 assert (c, length (d)); 
--> success=0, msg=test failed: raised error: tcp_read: Error while
reading/select: 22 - Invalid argument

[...]

>>>>> /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_read.cc-tst
[...]
***** test block 4: test
  is_test=1 is_xtest=0
Code:
 # does read wait
 a = udp ();
 assert (! isnull (a));
 tic;
 [d,c] = udp_read (a, 1, 1000);
 t = toc;
 assert (c, 0);
 assert (isempty (d));
 assert (t, 1.0, 0.1)
 udp_close (a); 
--> success=0, msg=test failed: raised error: udp_read: Error while
reading/select: 22 - Invalid argument

[...]

>>>>> /Users/janke/Library/Application
Support/Octave.app/4.4.1/pkg/instrument-control-0.4.0/test/udp_write.cc-tst
***** test block 1: test
  is_test=1 is_xtest=0
Code:
 a = udp ();
 b = udp ();
 p = get (a, 'localport');
 set (b, 'remoteport', p);
 p = get (b, 'localport');
 set (a, 'remoteport', p);
 assert (5, udp_write (a, uint8 ([104  101  108  108  111])));
 [d, c] = udp_read (b, 5, 1000);
 assert (c, 5);
 assert (d, uint8 ([104  101  108  108  111]));
 udp_close (a);
 udp_close (b); 
--> success=0, msg=test failed: raised error: udp_read: Error while
reading/select: 22 - Invalid argument



I'm attaching a file with the full test run details.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 20 Oct 2019 08:00:55 AM EDT  Name: instrument-control_tests.txt 
Size: 23KiB   By: apjanke

<http://savannah.gnu.org/bugs/download.php?file_id=47721>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57087>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/