[Octave-bug-tracker] [bug #57386] [octave forge] (nan) Please declare functions with internal linkage as static

[Stefan Brüns]

URL:
  <https://savannah.gnu.org/bugs/?57386>

                 Summary: [octave forge] (nan) Please declare functions with
internal linkage as static
                 Project: GNU Octave
            Submitted by: stefanbruens
            Submitted on: Mon 09 Dec 2019 04:15:55 PM UTC
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Feature Request
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

(At least) the following functions are defined with external linkage, although
they are just internal helpers:

svmtrain_mex.cpp:
- print_null
- print_string_matlab
- exit_with_help
- do_cross_validation

svmpredict_mex.cpp:
- print_null
- predict
- exit_with_help

Typically, anything but mexFunction should be declared with internal linkage
(i.e. either as "static" or within an anonymous namespace (C++ only)).

This allows the compiler to generate better code and avoids exposing internal
symbols.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57386>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/