[Octave-bug-tracker] [bug #57403] pkg.m loads packages before their dependencies

[Philip Nienhuis]

Update of bug #57403 (project octave):

                  Status:                    None => Patch Submitted        

    _______________________________________________________

Follow-up Comment #1:

As Savannah still seems to bemixed-up, I'll attach the patches "inline":


# HG changeset patch
# User Philip Nienhuis <address@hidden>
# Date 1576233445 -3600
#      Fri Dec 13 11:37:25 2019 +0100
# Node ID fa607747531b8b743fd97296ac67000da7fe9245
# Parent  459472431edaea329875dc1e254c2ab79f359f37
pkg.m: fix order in which packages and their dependencies are loaded (bug
#57403)

diff -r 459472431eda -r fa607747531b
scripts/pkg/private/load_packages_and_dependencies.m
--- a/scripts/pkg/private/load_packages_and_dependencies.m      Fri Dec 13 
11:34:36
2019 +0100
+++ b/scripts/pkg/private/load_packages_and_dependencies.m      Fri Dec 13 
11:37:25
2019 +0100
@@ -45,7 +45,7 @@
 
   ## Load the packages.
   if (length (dirs) > 0)
-    addpath (dirs{:});
+    addpath (fliplr (dirs{:}));
   endif
 
   ## Add the binaries to exec_path.


and the addpath / loadpath.cc patch:

# HG changeset patch
# User Philip Nienhuis <address@hidden>
# Date 1576233276 -3600
#      Fri Dec 13 11:34:36 2019 +0100
# Node ID 459472431edaea329875dc1e254c2ab79f359f37
# Parent  bad702797afb9ee256cc9031de054b011f74a6f8
addpath: document order in which multiple directories are processed

diff -r bad702797afb -r 459472431eda libinterp/corefcn/load-path.cc
--- a/libinterp/corefcn/load-path.cc    Thu Dec 12 21:38:59 2019 -0800
+++ b/libinterp/corefcn/load-path.cc    Fri Dec 13 11:34:36 2019 +0100
@@ -2490,7 +2490,9 @@
 If @var{option} is @qcode{"-begin"} or 0 (the default), prepend the
 directory name to the current path.  If @var{option} is @qcode{"-end"}
 or 1, append the directory name to the current path.
-Directories added to the path must exist.
+Directories added to the path must exist.  If multiple directories are
+specified they are added to the path in reverse order, that is, first the
+rightmost directory is processed and lastly the leftmost one.
 
 In addition to accepting individual directory arguments, lists of
 directory names separated by @code{pathsep} are also accepted.  For example:


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57403>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/