[Octave-bug-tracker] [bug #64324] [Octave Packages] (statistics) BIST failures

[Arun Giridhar]

URL:
  <https://savannah.gnu.org/bugs/?64324>

                 Summary: [Octave Packages] (statistics) BIST failures
                   Group: GNU Octave
               Submitter: arungiridhar
               Submitted: Tue 20 Jun 2023 11:58:48 AM EDT
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Unexpected Error or Warning
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: dev
         Discussion Lock: Any
        Operating System: Any
           Fixed Release: None
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Tue 20 Jun 2023 11:58:48 AM EDT By: Arun Giridhar <arungiridhar>
With statistics 1.6.0, I am getting the following test failures.

Whether VM is enabled or not, these 8 errors show up about row / column
mismatch, and one index out of bounds:


>>>>> processing ..../statistics-1.6.0/dist_fit/gevfit.m
***** test
 x = 1:50;
 [pfit, pci] = gevfit (x);
 pfit_out = [-0.4407, 15.1923, 21.5309];
 pci_out = [-0.7532, 11.5878, 16.5686; -0.1282, 19.9183, 26.4926];
 assert (pfit, pfit_out, 1e-3);
 assert (pci, pci_out, 1e-3);
!!!!! test failed
horizontal dimensions mismatch (1x50 vs 50x1)
***** test
 x = 1:2:50;
 [pfit, pci] = gevfit (x);
 pfit_out = [-0.4434, 15.2024, 21.0532];
 pci_out = [-0.8904, 10.3439, 14.0168; 0.0035, 22.3429, 28.0896];
 assert (pfit, pfit_out, 1e-3);
 assert (pci, pci_out, 1e-3);
!!!!! test failed
horizontal dimensions mismatch (1x25 vs 25x1)


>>>>> processing ..../statistics-1.6.0/correlation_test.m
***** test
 x = [6 7 7 9 10 12 13 14 15 17];
 y = [19 22 27 25 30 28 30 29 25 32];
 [h, pval, stats] = correlation_test (x, y);
 assert (stats.corrcoef, corr (x, y), 1e-14);
 assert (pval, 0.0223, 1e-4);
!!!!! test failed
c(10,_): out of bound 1 (dimensions are 1x1)


>>>>> processing ..../statistics-1.6.0/violin.m
***** test
 set (0, "DefaultFigureVisible", "off");
 data = exprnd (0.1, 500,4);
 violin (data, "color", jet(4));
 axis ([0 5 0 max(data(:))])
 set (0, "DefaultFigureVisible", visibility_setting);
!!!!! test failed
horizontal dimensions mismatch (4x1 vs 1x1)
shared variables     visibility_setting = on
***** test
 set (0, "DefaultFigureVisible", "off");
 data = {randn(100,1)*5+140, randn(130,1)*8+135};
 subplot (1,2,1)
 title ("Grade 3 heights - vertical");
 set (gca, "xtick", 1:2, "xticklabel", {"girls"; "boys"});
 violin (data, "Nbins", 10);
 axis tight
 set (0, "DefaultFigureVisible", visibility_setting);
!!!!! test failed
horizontal dimensions mismatch (4x1 vs 1x1)
shared variables     visibility_setting = on
***** test
 set (0, "DefaultFigureVisible", "off");
 data = {randn(100,1)*5+140, randn(130,1)*8+135};
 subplot (1,2,1)
 title ("Grade 3 heights - vertical");
 set (gca, "xtick", 1:2, "xticklabel", {"girls"; "boys"});
 violin (data, "Nbins", 10);
 axis tight
 subplot(1,2,2)
 title ("Grade 3 heights - horizontal");
 set (gca, "ytick", 1:2, "yticklabel", {"girls"; "boys"});
 violin (data, "horizontal", "Nbins", 10);
 axis tight
 set (0, "DefaultFigureVisible", visibility_setting);
!!!!! test failed
horizontal dimensions mismatch (4x1 vs 1x1)
shared variables     visibility_setting = on
***** test
 set (0, "DefaultFigureVisible", "off");
 data = repmat(exprnd (0.1, 500,1), 1, 4);
 violin (data, "nbins", [5,10,50,100], "smoothfactor", [4 4 8 10]);
 axis ([0 5 0 max(data(:))])
 set (0, "DefaultFigureVisible", visibility_setting);
!!!!! test failed
horizontal dimensions mismatch (3x1 vs 1x1)
shared variables     visibility_setting = on
***** test
 set (0, "DefaultFigureVisible", "off");
 data = repmat(exprnd (0.1, 500,1), 1, 4);
 violin (data, "width", linspace (0.1,0.5,4));
 axis ([0 5 0 max(data(:))])
 set (0, "DefaultFigureVisible", visibility_setting);
!!!!! test failed
horizontal dimensions mismatch (4x1 vs 1x1)
shared variables     visibility_setting = on


When VM is enabled, there are some 26 additional errors where the expected
error is "functionname: function called with too many inputs" but the actual
error omits the function name and just gives "function called with too many
inputs". Looking through the packages and the Octave code base, it seems that
only the Statistics package adds the function name to the expected error,
causing a BIST failure when the VM-compiled version is used instead. A patch
("git diff") is attached to remove those function names from the error
messages.







    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Tue 20 Jun 2023 11:58:48 AM EDT  Name: statistics.patch  Size: 18KiB  
By: arungiridhar

<http://savannah.gnu.org/bugs/download.php?file_id=54848>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64324>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/