[Octave-bug-tracker] [bug #65221] movfun: create inputParser only once.

[Rik]

Update of bug#65221 (group octave):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                 
           Fixed Release:                    None => 10.1.0 (current default)

    _______________________________________________________

Follow-up Comment #1:

Good catch.  I wrote a small test script to benchmark performance.


N = 100;

x = [1:3e4];

y = movmean (x, 20, 'includenan');

tic
for i = 1:N
  y = movmean (x, 20, 'includenan');
endfor
toc


Current code: 0.86 seconds
Patched code: 0.80 seconds
% change: -6%

  The change isn't large.  Nevertheless, it is an easy win.  I checked in your
changeset here https://hg.savannah.gnu.org/hgweb/octave/rev/4df9460ab8a9.  I
made two tweaks to follow Octave coding guidelines: 1) use space between 'if'
and condition wrapped in parentheses, 2) use specific end keyword, in this
case 'endif', instead of generic 'end'.

Marking bug as Fixed and closing report.







    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65221>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/