[Octave-bug-tracker] [bug #65200] Special nil octave_base_value class to speed up octave_value dtors

[Petter]

Follow-up Comment #8, bug#65200 (group octave):


> I haven't quite understood why overloading only the clone function is enough
to achieve something equivalent. Or did I misunderstand the idea behind the
patch?

The reasoning was that the special nil class should return it self on a
clone(), not return a octave_base_value as it would if the clone() function
was not overloaded, to save a construction of an object. 

But I've backtracked on increasing m_count with 1 solving any problem, so it
shouldn't matter since the class is unnecessary.

> In the nil_rep changeset, what is meant by the comment "// Also increased in
octave_base_value()"?  I don't see any change to the octave_base_value default
constructor.

I should have written "Is set to 1 in octave_base_value". I tried to convey it
would end up at 2. But I realized I was wrong about that being a problem in
the first place.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65200>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/