[Octave-bug-tracker] [bug #65497] fits 1.0.7: type cast issue

[Dmitri A. Sergatskov]

Follow-up Comment #1, bug #65497 (group octave):

Can reproduce on linux:

octave:1> pkg install -forge -verbose fits
downloading tarball(s) from:
- https://packages.octave.org/download/fits-1.0.7.tar.gz
mkdir (/tmp/oct-eW8yCj)
untar (/tmp/fits-1.0.7-BHbOTU.tar.gz, /tmp/oct-eW8yCj)
make: Entering directory '/tmp/oct-eW8yCj/fits-1.0.7/src'
mkoctfile --verbose -Wall -I/usr/include/cfitsio -lcfitsio 
read_fits_image.cc
g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-9.1.1/octave/..
-I/usr/local/include/octave-9.1.1/octave -I/usr/local/include  -pthread
-fopenmp -Wall -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto 
-Wall  -I/usr/include/cfitsio  read_fits_image.cc -o /tmp/oct-K0kcKT.o
mkoctfile --verbose -Wall -I/usr/include/cfitsio -lcfitsio 
save_fits_image.cc
g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-9.1.1/octave/..
-I/usr/local/include/octave-9.1.1/octave -I/usr/local/include  -pthread
-fopenmp -Wall -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto 
-Wall  -I/usr/include/cfitsio  save_fits_image.cc -o /tmp/oct-SJBDBU.o
mkoctfile --verbose -Wall -I/usr/include/cfitsio -lcfitsio 
save_fits_image_multi_ext.cc
g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-9.1.1/octave/..
-I/usr/local/include/octave-9.1.1/octave -I/usr/local/include  -pthread
-fopenmp -Wall -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto 
-Wall  -I/usr/include/cfitsio  save_fits_image_multi_ext.cc -o
/tmp/oct-oGy6z9.o
save_fits_image.cc: In function ‘octave_value_list Fsave_fits_image(const
octave_value_list&, int)’:
save_fits_image.cc:84:12: error: ‘D_NINT’ was not declared in this scope
   84 |       if( (D_NINT( val ) ==  val) )
      |            ^~~~~~
save_fits_image.cc:132:58: error: passing ‘const NDArray’ as ‘this’
argument discards qualifiers [-fpermissive]
  132 |   double * datap = const_cast<double*>( image.fortran_vec() );
      |                                         ~~~~~~~~~~~~~~~~~^~
In file included from
/usr/local/include/octave-9.1.1/octave/../octave/Array-util.h:31,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/MSparse.h:31,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/MatrixType.h:33,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/mx-base.h:33,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/Matrix.h:34,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/oct.h:33,
                 from save_fits_image.cc:19:
/usr/local/include/octave-9.1.1/octave/../octave/Array.h:666:20: note:   in
call to ‘T* Array<T, Alloc>::fortran_vec() [with T = double; Alloc =
std::pmr::polymorphic_allocator<double>]’
  666 |   OCTARRAY_API T * fortran_vec ();
      |                    ^~~~~~~~~~~
make: *** [Makefile:9: save_fits_image.oct] Error 1
make: *** Waiting for unfinished jobs....
read_fits_image.cc: In function ‘bool any_bad_argument(const
octave_value_list&)’:
read_fits_image.cc:197:10: error: ‘D_NINT’ was not declared in this scope
  197 |     if( (D_NINT( val ) !=  val) || (val < 0) )
      |          ^~~~~~
save_fits_image_multi_ext.cc: In function ‘octave_value_list
Fsave_fits_image_multi_ext(const octave_value_list&, int)’:
save_fits_image_multi_ext.cc:81:12: error: ‘D_NINT’ was not declared in
this scope
   81 |       if( (D_NINT( val ) ==  val) )
      |            ^~~~~~
save_fits_image_multi_ext.cc:140:60: error: passing ‘const NDArray’ as
‘this’ argument discards qualifiers [-fpermissive]
  140 |     double * datap = const_cast<double*>( image.fortran_vec() );
      |                                           ~~~~~~~~~~~~~~~~~^~
In file included from
/usr/local/include/octave-9.1.1/octave/../octave/Array-util.h:31,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/MSparse.h:31,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/MatrixType.h:33,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/mx-base.h:33,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/Matrix.h:34,
                 from
/usr/local/include/octave-9.1.1/octave/../octave/oct.h:33,
                 from save_fits_image_multi_ext.cc:19:
/usr/local/include/octave-9.1.1/octave/../octave/Array.h:666:20: note:   in
call to ‘T* Array<T, Alloc>::fortran_vec() [with T = double; Alloc =
std::pmr::polymorphic_allocator<double>]’
  666 |   OCTARRAY_API T * fortran_vec ();
      |                    ^~~~~~~~~~~
make: *** [Makefile:9: read_fits_image.oct] Error 1
make: *** [Makefile:9: save_fits_image_multi_ext.oct] Error 1
make: Leaving directory '/tmp/oct-eW8yCj/fits-1.0.7/src'

error: pkg: error running 'make' for the fits package
error: called from
    configure_make at line 117 column 9
    install at line 202 column 7
    pkg at line 619 column 9


Dmitri.
-- 



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65497>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/