[Octave-bug-tracker] [bug #65808] "octave.bat" does not work in case the PATH variable contains directories with spaces

[anonymous]

Follow-up Comment #5, bug #65808 (group octave):

Hello Markus,

yes, the line ends of these files have been changed using unix2dos.

Please use the files in folder "modified/installer-files" for the update
instead of installer_files.patch.

See details below.

Best regards
Michael


I downloaded the sources from the Mercurial repository website via the "raw"
links.
Then I applied unix2dos to all four files since the patches:
cmdshell-no-short-path.patch
octave-bat-no-short-path.patch

could not be applied directly using "patch" command under cygwin:

$ patch -p1 < octave-bat-no-short-path.patch
patching file octave.bat
Assertion failed: hunk, file .\src\patch\2.5.9\patch-2.5.9-src\patch.c, line
354

$ patch -p1 < cmdshell-no-short-path.patch
patching file cmdshell.bat
Assertion failed: hunk, file .\src\patch\2.5.9\patch-2.5.9-src\patch.c, line
354


So I applied unix2dos to all four files:

$ unix2dos *
unix2dos: converting file cmdshell-no-short-path.patch to DOS format...
unix2dos: converting file cmdshell.bat to DOS format...
unix2dos: converting file octave-bat-no-short-path.patch to DOS format...
unix2dos: converting file octave.bat to DOS format...

=> The files which have been processed by unix2dos have been used then for
applying the fix with the double quotes.

Then the patches from the repository could be applied:

$ patch -p1 < cmdshell-no-short-path.patch
patching file cmdshell.bat
$ patch -p1 < octave-bat-no-short-path.patch
patching file octave.bat
Hunk #2 succeeded at 66 (offset 25 lines).



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65808>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/