[Octave-bug-tracker] [bug #55961] properties function does not preserve order

[Markus Mützel]

Update of bug #55961 (group octave):

                Category:         Octave Function => Classdef               
         Planned Release:                    None => 10.1.0 (current default)

    _______________________________________________________

Follow-up Comment #5:

@ies: Sorry for taking so long to finally review your patch. It's now more
than 5 years since you originally submitted it. And - of course - it no longer
applies on a current head.

The attached patch is rebased on a current head. (Almost every line had to be
changed manually...)

Afaict, `make check` still passes. (But I have a lot of local changes that
cause some unrelated test failures. I hope I didn't miss relevant errors.)
It would probably be nice to add (at least one) BIST to make sure this change
is working as expected with inheritance and doesn't regress in the future. The
classes from comment #2 would probably work.

The proposed changes would modify the API in a non-backwards compatible way. I
don't know if anyone is using the affected functions and typedefs though. So,
this might not be an issue when it comes to existing code.
Usually, we deprecate existing functions for 2 major versions before
eventually removing them. We probably could do the same here. I'm not sure
this is worth the effort in this particular case though.

@maintainers: Would it be ok to change the C++ API in this case without
keeping backwards-compatible deprecated functions and typedefs? (I don't know
how typedefs could be deprecated though...)


(file #56214)

    _______________________________________________________

Additional Item Attachment:

File name: bug55961-classdef-properties-order-v2.patch Size: 12KiB
   
<https://file.savannah.gnu.org/file/bug55961-classdef-properties-order-v2.patch?file_id=56214>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-5d3a3fbe50e425e975009727b4a24877be503f9a.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55961>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature