[Octave-bug-tracker] [bug #66754] Signal Package: findpeaks.m has inconsistent default values for minW variable

[Rik]

Update of bug #66754 (group octave):

                Category:               Libraries => Octave Package
                  Status:                    None => Confirmed
                 Summary: Signal Processing->findpeaks.m  inconsistent default
values for minW variable   => Signal Package: findpeaks.m  has inconsistent
default values for minW variable

    _______________________________________________________

Follow-up Comment #1:

You are correct that there is an inconsistency here.  The package code is
attempting to support very ancient versions of core Octave (4.0) as well as
the general package.  That seems completely unnecessary.  My preferred fix
would simply be to remove the old code (lines 149-174).  The input parser
defined at line 140 should then use whatever the correct value of MinPeakWidth
is (eps or 1).  I've added the listed maintainer (Mike Miller) to the CC list
for this bug, but I'm not sure he is still active.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66754>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature