Re: wrong use of color_property in patch.facecolor

[David Bateman]

Shai Ayal wrote:
> Hi
>
> I noticed a wrong use for setting the color property. It relates to
> the problems we discussed on setting radio_value based properties.
>
> the property is patch.facecolor. The way it should have been
> implemented is using the attached patch. Note that this way avoids the
> duplication of the allowed radio_values both in
> patch::properties::properties and in patch::properties::set by using
> the "a" modifier in the property declaration
>
> It also eliminates the need to change
> color_property::color_property(const octave_value&).
>
> Shai
>
> 2007-09-29  Shai Ayal  <address@hidden>
>
>       * graphics.cc ((color_property::color_property (const
>       octave_value& val)): Undo change from 2007-09-26
>       (patch::properties::properties): use the "a" modifier to
>       face_color & edge_color properties
>       (patch::properties::set): Undo change from 2007-09-26
>       * graphics.h.in (color_property::color_property
>       (const octave_value& val)): Undo change from 2007-09-26
>   
Given John's go ahead I applied this patch.

D.

-- 
David Bateman                                address@hidden
Motorola Labs - Paris                        +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 6 72 01 06 33 (Mob) 
91193 Gif-Sur-Yvette FRANCE                  +33 1 69 35 77 01 (Fax) 

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary