[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tests for slicing of sparse matrices
From: |
John W. Eaton |
Subject: |
Re: Tests for slicing of sparse matrices |
Date: |
Thu, 10 Jan 2008 04:23:47 -0500 |
On 10-Jan-2008, Kim Hansen wrote:
| On Jan 10, 2008 9:53 AM, David Bateman <address@hidden> wrote:
| >
| > John W. Eaton wrote:
| > > On 10-Jan-2008, David Bateman wrote:
| > >
| > > | Except that perhaps we should have at least complex versions of these
| > > | tests, this is a valuable addition and should be included in the test
| > > | suite. John can we commit this file?
| > >
| > > Yes, but wouldn't it be better to include these in the source file(s)
| > > that implement the feature(s) rather than adding new files to the test
| > > directory?
| > >
| > > jwe
| > >
| > >
| > If you prefer. In that case it goes near the entire file goes near the
| > Sparse<T>::assign function in liboctave/Sparse.cc as these tests only
| > test Sparse<T>::assign and Sparse<T>::assign1
|
| This patch should place the tests after Sparse::assign in liboctave/Sparse.cc
|
| 2008-01-10 Kim Hansen <address@hidden>
|
| * liboctave/Sparse.cc: Tests for slicing of sparse matrices
I applied it and checked it in.
Thanks,
jwe