Re: Should the attached be applied?

[David Bateman]

Jaroslav Hajek wrote:
> On Thu, Nov 13, 2008 at 11:09 PM, David Bateman <address@hidden> wrote:
>   
> > I think we need the patch
> >
> > diff --git a/liboctave/Array2.h b/liboctave/Array2.h
> > --- a/liboctave/Array2.h
> > +++ b/liboctave/Array2.h
> > @@ -117,14 +117,14 @@
> >    }
> >
> >  Array2<T> index (idx_vector& i, int resize_ok = 0,
> > -           const T& rfv = resize_fill_value (T ())) const
> > +           const T& rfv = Array<T>::resize_fill_value ()) const
> >    {
> >      Array<T> tmp = Array<T>::index (i, resize_ok, rfv);
> >      return Array2<T> (tmp, tmp.rows (), tmp.columns ());
> >    }
> >
> >  Array2<T> index (idx_vector& i, idx_vector& j, int resize_ok = 0,
> > -           const T& rfv = resize_fill_value (T ())) const
> > +           const T& rfv = Array<T>::resize_fill_value ()) const
> >    {
> >      Array<T> tmp = Array<T>::index (i, j, resize_ok, rfv);
> >      return Array2<T> (tmp, tmp.rows (), tmp.columns ());
> >
> > But perhaps Jaroslav should comment as this touches on his recent indexing
> > changes..
> >
> >     
>
> Yes. I'm a little surprised that this went unnoticed - apparently that
> method is not instantiated anywhere in Octave.
>
>   
Well its instantiated in the octave-forge fixed package, which is how I 
came across this issue. I'll commit this change now.

Regards
David

--
David Bateman                                address@hidden
Motorola Labs - Paris                        +33 1 69 35 48 04 (Ph) 
Parc Les Algorithmes, Commune de St Aubin    +33 6 72 01 06 33 (Mob) 
91193 Gif-Sur-Yvette FRANCE                  +33 1 69 35 77 01 (Fax) 

The information contained in this communication has been classified as: 

[x] General Business Information 
[ ] Motorola Internal Use Only 
[ ] Motorola Confidential Proprietary