[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: need someone to check a changeset
From: |
Ben Abbott |
Subject: |
Re: need someone to check a changeset |
Date: |
Wed, 01 Sep 2010 17:59:09 -0400 |
On Sep 1, 2010, at 5:27 PM, Jordi GutiƩrrez Hermoso wrote:
> On 31 August 2010 20:15, Ben Abbott <address@hidden> wrote:
>> As trivial as this changeset is, my c\c++ skill are so poor that I'd
>> like someone to take a quick look before I push it.
>>
>> https://savannah.gnu.org/bugs/index.php?30872
>
> I think you exaggerate your C++ incompetence. ;-)
>
> The patch looks fine and does fix Marco's problem. Why does it work,
> though? Why is lo the right thing to raise 10 instead of
> floor(lo/ticks)? Couldn't lo itself potentially be tiny enough to make
> 10^low == 0 ?
>
> - Jordi G. H.
I assume that lo = log10(min(y(y>0))), if so 10^lo can't equal zero.
If there is no objection I'll push this in a few hours.
Ben
- Re: need someone to check a changeset, Jordi GutiƩrrez Hermoso, 2010/09/01
- Re: need someone to check a changeset,
Ben Abbott <=
- Message not available
- Message not available
- Re: wait_for_file ??, Michael D Godfrey, 2010/09/03
- Re: wait_for_file ??, Shai Ayal, 2010/09/03
- Re: wait_for_file ??, Michael D Godfrey, 2010/09/03
- Re: wait_for_file ??, Michael D Godfrey, 2010/09/03
- Re: wait_for_file ??, Shai Ayal, 2010/09/03
- Re: wait_for_file ??, Olaf Till, 2010/09/03
- Re: wait_for_file ??, Michael D Godfrey, 2010/09/03
- Re: wait_for_file ??, Michael D Godfrey, 2010/09/03