compile error on oct-env.cc in building octave-3.3.52+ on MinGW32

[John W. Eaton]

On 22-Sep-2010, Tatsuro MATSUOKA wrote:

| libtool: compile:  g++ -shared-libgcc -DHAVE_CONFIG_H -I. 
-I../../../hg/octave-work/liboctave -I..
| -I/c/Programs/gpnewlib/include -I/c/Programs/OctaveLibs/include 
-I/GnuWin32/include -I../libgnu
| -I../../../hg/octave-work/libgnu -I../../../hg/octave-work/libcruft/misc
| -I/c/Programs/gpnewlib/include -I/c/Programs/OctaveLibs/include 
-I/GnuWin32/include -O3
| -fomit-frame-pointer -DHAVE_CONFIG_H -mieee-fp -IC:/Programs/GnuWin32/include
| -I/c/Programs/gpnewlib/include/freetype2 -I/c/Programs/gpnewlib/include 
-IC:/Programs/gpnewlib/include
| -Wall -W -Wshadow -Wold-style-cast -Wformat -O3 -fomit-frame-pointer -O3 
-fomit-frame-pointer -MT
| liboctave_la-oct-env.lo -MD -MP -MF .deps/liboctave_la-oct-env.Tpo -c
| ../../../hg/octave-work/liboctave/oct-env.cc  -DDLL_EXPORT -DPIC -o 
.libs/liboctave_la-oct-env.o
| In file included from ../../../hg/octave-work/liboctave/oct-env.cc:61:0:
| ../../../hg/octave-work/liboctave/oct-syscalls.h:61:62: error: macro 
"waitpid" passed 4 arguments, but
| takes just 3
| ../../../hg/octave-work/liboctave/oct-syscalls.h:60:16: error: expected 
identifier before numeric
| constant
| ../../../hg/octave-work/liboctave/oct-syscalls.h:60:16: error: expected ',' 
or '...' before numeric
| constant

It looks like the gnulib sys/wait.h is defining waitpid, even for C++.
Probably it should not do that.

| ../../../hg/octave-work/liboctave/oct-env.cc: In member function 'std::string
| octave_env::do_get_host_name() const':
| ../../../hg/octave-work/liboctave/oct-env.cc:455:20: error: 'gethostname' is 
not a member of 'gnulib'

The unistd.h file from gnulib should provide gnulib::gethostname.  Are
the following defined in your configh.h file?

  GNULIB_TEST_GETHOSTNAME
  HAVE_GETHOSTNAME
  HAVE_RAW_DECL_GETHOSTNAME

jwe