Re: build without gnuplot

[Ben Abbott]

On Apr 24, 2012, at 2:37 PM, Svante Signell wrote:

> What about something like the below (has to be tested of course)
> 
> On Tue, 2012-04-24 at 13:59 -0400, Ben Abbott wrote:
>> On Apr 24, 2012, at 12:26 PM, Mike Miller wrote:
>> 
>>> On Tue, Apr 24, 2012 at 11:28 AM, Ben Abbott <address@hidden> wrote:
>>>> Any autotools experts know how difficult it would be to check to see if 
>>>> gnuplot exists before trying to build the docs ?
>>>> 
>>>>       https://savannah.gnu.org/bugs/index.php?36255
>>> 
>>> No need, the check is already done, $GNUPLOT and $warn_gnuplot
>>> variables are set appropriately, just need a new check at the end to
>>> combine the pieces, print a message, and disable the doc conditional.
>>> 
>>> -- 
>>> mike
>> 
>> In configure.ac I see the pieces below, but am not familiar with the 
>> details. What needs to be done to --disable-docs ?
>> 
>> 188 ### Make it possible to disable running Make in the doc directory.
>> 189 ### Useful for building on systems without TeX, for example.
>> 190 DOCDIR=doc
>> 191 AC_ARG_ENABLE(docs,
>> 192   [AS_HELP_STRING([--enable-docs], [build documentation (default is 
>> yes)])],
>> 193   [if test "$enableval" = no; then
>> 194      DOCDIR=
>> 195      warn_docs="building documentation disabled; make dist will fail"
>> 196      AC_MSG_WARN([$warn_docs])
>> 197    fi], [])
>> 198 AC_SUBST(DOCDIR)
>> 199 AM_CONDITIONAL([AMCOND_BUILD_DOCS], [test -n "$DOCDIR"])
>> 
>> 
>> 2484 if test -n "$warn_gnuplot"; then
>> 2485   if $native_graphics; then
>> 2486     AC_MSG_WARN([])
>> 2487     AC_MSG_WARN([I didn't find gnuplot.  Plotting commands will use 
>> the])
>> 2488     AC_MSG_WARN([native graphics toolkit.])
>> 2489   else
>> 2490     AC_MSG_WARN([I didn't find gnuplot.  It isn't necessary to have 
>> gnuplot])
>> 2491     AC_MSG_WARN([installed, but you won't be able to use any of 
>> Octave's])
>> 2492     AC_MSG_WARN([plotting commands without it.])
>> 2493   fi
>> 2494   AC_MSG_WARN([])
>> 2495   AC_MSG_WARN([If gnuplot is installed, but isn't in your path, you 
>> can])
>> 2496   AC_MSG_WARN([tell Octave where to find it by using the 
>> gnuplot_binary])
>> 2497   AC_MSG_WARN([function.  For example,])
>> 2498   AC_MSG_WARN([])
>> 2499   AC_MSG_WARN([gnuplot_binary 
>> ("/full/path/and/name/of/gnuplot/binary")])
>> 2500   AC_MSG_WARN([])
>> 2501   AC_MSG_WARN([at the Octave prompt.])
>> 2502   AC_MSG_WARN([])
>> 2503   AC_MSG_WARN([Setting default value to $GNUPLOT])
>> 2504   AC_MSG_WARN([])
>> 2505 
>> 2506   warn_msg_printed=true
>  DOCDIR=
>  warn_docs="building documentation disabled; gnuplot not found"
>  AC_MSG_WARN([$warn_docs])
>> 2507 fi
> 
> Don't know what happens if --enable-docs is given and gnuplot is missing
> though. Then both tests have to be combined.

I tried ...

$ hg diff
diff --git a/configure.ac b/configure.ac
--- a/configure.ac
+++ b/configure.ac
@@ -2483,6 +2483,9 @@
     AC_MSG_WARN([installed, but you won't be able to use any of Octave's])
     AC_MSG_WARN([plotting commands without it.])
   fi
+  DOCDIR=
+  AC_MSG_WARN([])
+  AC_MSG_WARN([Building the documentation has been disabled.])
   AC_MSG_WARN([])
   AC_MSG_WARN([If gnuplot is installed, but isn't in your path, you can])
   AC_MSG_WARN([tell Octave where to find it by using the gnuplot_binary])

And my build ended with ...

/bin/sh ../../libtool --tag=CXX   --mode=link /opt/local/bin/g++-mp-4.6 -pipe 
-O2 -g -m64 -ggdb3  -DHAVE_CONFIG_H -I/opt/local/include 
-I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include   
-Wall -W -Wshadow -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings 
-Wcast-align -Wcast-qual -pipe -O2 -g -m64 -ggdb3 -D_THREAD_SAFE -pthread -pipe 
-O2 -g -m64 -ggdb3  -L/opt/local/lib -o munge-texi munge-texi.o  -lm  
libtool: link: /opt/local/bin/g++-mp-4.6 -pipe -O2 -g -m64 -ggdb3 
-DHAVE_CONFIG_H -I/opt/local/include -I/opt/local/include/freetype2 
-I/opt/local/include -I/opt/local/include -Wall -W -Wshadow -Wold-style-cast 
-Wformat -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -pipe -O2 -g 
-m64 -ggdb3 -D_THREAD_SAFE -pthread -pipe -O2 -g -m64 -ggdb3 -o munge-texi 
munge-texi.o -Wl,-bind_at_load  -L/opt/local/lib -lm -pthread
../../run-octave -f -q -H -p . --eval "geometryimages ('voronoi', 'eps');"
sh: gnuplot: command not found
error: popen2: popen2 (child): unable to start process -- No such file or 
directory
error: called from:
error:   
/Users/bpabbott/Development/mercurial/experimental/scripts/plot/private/__gnuplot_open_stream__.m
 at line 30, column 44
error:   
/Users/bpabbott/Development/mercurial/experimental/scripts/plot/__gnuplot_drawnow__.m
 at line 39, column 19
error:   
/Users/bpabbott/Development/mercurial/experimental/scripts/plot/private/__gnuplot_print__.m
 at line 192, column 5
error:   
/Users/bpabbott/Development/mercurial/experimental/scripts/plot/private/__gnuplot_print__.m
 at line 176, column 5
error:   
/Users/bpabbott/Development/mercurial/experimental/scripts/plot/private/__gnuplot_print__.m
 at line 68, column 7
error:   
/Users/bpabbott/Development/mercurial/experimental/scripts/plot/print.m at line 
380, column 12
error:   
/Users/bpabbott/Development/mercurial/experimental/doc/interpreter/geometryimages.m
 at line 55, column 5
error: stdin is not a tty!
warning: broken pipe -- some output may be lost

It appears "make" is still trying to build the docs.

Ben