Re: 49 test failures

[Max Brister]

On Mon, Jul 23, 2012 at 5:40 PM, c. <address@hidden> wrote:
> Hi,
>
> After building the most recent tip
>
> ----------------------------------------------------------
> $ hg id
> 74c7265c057a tip
> ----------------------------------------------------------
>
> I get 49 test failures for 'test_func.m' i.e. ALL tests fail.
> If I run the test manually it seems the problem is with the definition of the 
> function
> __fntestfunc__ not being shared by different test blocks:
>
> ----------------------------------------------------------
> $ ./run-octave -q -f -H
> octave:1> cd test
> octave:2> test test_func
>   ***** test
>  __fntestfunc__("triu", m1, {"struct"});
> !!!!! test failed
> `__fntestfunc__' undefined near line 3 column 2
> shared variables
>   scalar structure containing the fields:
>
>     m0 =
>
>        1   2   3   4   5
>
>     m1 =
>
>         1    6   11   16   21   26
>         2    7   12   17   22   27
>         3    8   13   18   23   28
>         4    9   14   19   24   29
>         5   10   15   20   25   30
>
>     m2 =
>
>     ans(:,:,1) =
>
>        1
>        2
>        3
>        4
>        5
>
>     ans(:,:,2) =
>
>         6
>         7
>         8
>         9
>        10
>
>     ans(:,:,3) =
>
>        11
>        12
>        13
>        14
>        15
>
>     ans(:,:,4) =
>
>        16
>        17
>        18
>        19
>        20
>
>     ans(:,:,5) =
>
>        21
>        22
>        23
>        24
>        25
>
>     ans(:,:,6) =
>
>        26
>        27
>        28
>        29
>        30
>
>     m3 = [](0x0)
>
> ----------------------------------------------------------
>
> Does anyone have any idea what might be going wrong?
> c.

This was caused by my patch to clear command line functions.
Apparently test.m attempts to clear %!function blocks after processing
a %!shared block. This never worked properly before, as command line
functions were not cleared.

After talking to Rik, it looks like the correct fix is to not clear
%!function blocks after processing a shared block (the old behavior).
Instead they will be cleared after processing all tests in the file.

Max Brister