[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when inc
|
From: |
Jordi Gutiérrez Hermoso |
|
Subject: |
Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++ |
|
Date: |
Fri, 3 Aug 2012 09:51:55 -0400 |
On 2 August 2012 23:40, Carlo de Falco <address@hidden> wrote:
>> From: Simon Josefsson <address@hidden>
>> Date: 2 August 2012 23:22:26 GMT+02:00
>> To: Carlo de Falco <address@hidden>
>> Cc: address@hidden
>> Subject: Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope
>> when included from C++
>>
>> Carlo de Falco <address@hidden> writes:
>>
>>> Hi,
>>>
>>> In order to use base64.h in GNU Octave we had to wrap the #include
>>> <"base64.h"> in extern "C" scope. We believe it would have been better
>>> if this had been done upstream. Would it be possible to apply the
>>> patch below to lib/base64.h ?
>>
>> Hi. I agree. Fixed in gnulib git master.
>>
>> Thanks,
>> /Simon
>
> Is it OK if I update the gnulib subrepo to get the new base64.h and push the
> change to mercurial?
Sure, it's ok to be fairly cavalier about updating the gnulib subrepo,
but just don't do it for no reason. Since there is reason to do so, I
think it should be upated.
- Jordi G. H.