Re: 'createStandardContextMenu' was not declared in this scope

[Ben Abbott]

On Jun 8, 2013, at 5:37 PM, Torsten wrote:
> On 08.06.2013 08:36, Torsten wrote:
>> On 08.06.2013 08:17, Daniel J Sebald wrote:
>>> On 06/08/2013 12:40 AM, Ben Abbott wrote:
>>>> On Jun 8, 2013, at 1:12 PM, Ben Abbott wrote:
>>>> 
>>>>> Torsten/all
>>> [snip]
>>> /src_libgui_src_la-file-editor.o
>>>>> src/m-editor/octave-qscintilla.cc: In member function 'virtual void
>>>>> octave_qscintilla::contextMenuEvent(QContextMenuEvent*)':
>>>>> src/m-editor/octave-qscintilla.cc:44:53: error:
>>>>> 'createStandardContextMenu' was not declared in this scope
>>>>> 
>>>>> I have qscintilla-2.4.6 and qt4-mac-4.8.4 installed.
>>>>> 
>>>>> Ben
>>>> 
>>>> After a bit of investigating, it appears that qscintilla 2.6.x is needed.
>>> 
>>> I must have installed qscintilla manually because I have 2.6.x, but my
>>> Fedora bundle from a year ago was running 2.4.x.  I can't remember much
>>> about it so it must have been easy to install.  We could condition the
>>> code on one of these definitions from the QScintilla headers:
>>> 
>>> qsciglobal.h:#define QSCINTILLA_VERSION      0x020602
>>> qsciglobal.h:#define QSCINTILLA_VERSION_STR  "2.6.2"
>>> 
>>> or require 2.6.x or higher.  Fedora, at least, is updating this package
>>> at a fairly quick pace:
>>> 
>>> Description
>>> QScintilla is a port of Scintilla to the Qt GUI toolkit. This version of
>>> QScintilla is based on Scintilla v3.2.3.
>>> Active Releases Overview
>>> Release     Latest Released Version     Version in Testing
>>> Rawhide     2.7.1-1.fc19     None
>>> Fedora 19     2.7.1-1.fc19     None
>>> Fedora 18     2.6.2-3.fc18     2.6.2-3.fc18 2 karma
>>> Fedora 17     2.6.1-2.fc17     None
>>> Fedora EPEL 6     2.4-1.el6     None
>> 
>> Sorry, I forgot to check the version where this function was introduced.
>> I will prepare a patch that checks for the appropriate qscintilla version.
> 
> Ben,
> could you please test the attached patch? It uses the existing (but now
> renamed) test for the newer finfFirst function which actually is a test
> for version 2.6.0.
> 
> Torsten

Torsten,  your patch works for me. Thanks!
Ben