Re: test fftfilt fail w/ current tip

[John W. Eaton]

On 07/23/2013 02:39 PM, Dmitri A. Sergatskov wrote:
> octave:3> test fftfilt
>    ***** test
>   b = [1 1];
>   x = [1, zeros(1,9)];
>   assert (fftfilt (b,  x  ), [1 1 0 0 0 0 0 0 0 0]  );
>   assert (fftfilt (b,  x.'), [1 1 0 0 0 0 0 0 0 0].');
>   assert (fftfilt (b.',x  ), [1 1 0 0 0 0 0 0 0 0]  );
>   assert (fftfilt (b.',x.'), [1 1 0 0 0 0 0 0 0 0].');
>   assert (fftfilt (b,  [x.' x.']), [1 1 0 0 0 0 0 0 0 0].'*[1 1]);
>   assert (fftfilt (b,  [x.'+eps x.']) == [1 1 0 0 0 0 0 0 0 0].'*[1 1],
> [false(10, 1) true(10, 1)]);
> !!!!! test failed
> assert (fftfilt (b, [x.' + eps, x.']) == [1, 1, 0, 0, 0, 0, 0, 0, 0,
> 0].' * [1, 1],[false(10, 1), true(10, 1)]) expected
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
> but got
>     1   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
>     0   1
> values do not match
> shared variables
>    scalar structure containing the fields:
>
>      b = [](0x0)
>      x = [](0x0)
>      r = [](0x0)
>
> hg tip
> changeset:   17035:08f0e372d006
> tag:         tip
> user:        Torsten <address@hidden <mailto:address@hidden>>
> date:        Mon Jul 22 23:18:50 2013 +0200
> summary:     doc viewer: correct the anchor position of the desired doc
> entry
>
> Test passes with 3.6.4.
>
> Dmitri.
> --

Yes, this has been failing ever since Dan and Jordi did some work on
fftfilt to fix bug #37297.

I think the relevant changesets are

  changeset:   16436:39847dcd2568
  user:        Jordi Gutiérrez Hermoso <address@hidden>
  date:        Thu Apr 04 17:18:16 2013 -0400
  summary:     * fftfilt.m: simplify computation of xisreal and xisimag

  changeset:   16429:586972e3ea7a
  parent:      16414:610e02bf9579
  user:        Daniel J Sebald <address@hidden>
  date:        Wed Apr 03 18:23:36 2013 -0500
  summary:     Correct errors in the fftfilt rounding (bug #37297), add 
more robust tests.


jwe